Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Unified Diff: ui/aura/mus/window_mus.h

Issue 2470963002: Makes it possible for clients to directly create WindowTreeHostMus (Closed)
Patch Set: includes Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/aura/mus/window_mus.h
diff --git a/ui/aura/mus/window_mus.h b/ui/aura/mus/window_mus.h
index 13018ca58b69dfbb27541ead3b19a6ffbf5f79b1..6b20c8d0edebf1863df5f8d5940fdb2ed9636651 100644
--- a/ui/aura/mus/window_mus.h
+++ b/ui/aura/mus/window_mus.h
@@ -56,8 +56,8 @@ class AURA_EXPORT WindowMus {
// |create_remote_window| indicates whether a window should be created on the
// server. Generally |create_remote_window| should be true, only in rare
// exceptions (such as the root of a WindowTreeHost) is it false.
sadrul 2016/11/02 16:03:04 Update the doc?
sky 2016/11/02 16:53:23 I nuked it. There isn't really much to say.
- explicit WindowMus(bool create_remote_window)
- : create_remote_window_(create_remote_window) {}
+ explicit WindowMus(WindowMusType window_mus_type)
+ : window_mus_type_(window_mus_type) {}
virtual ~WindowMus() {}
// Returns the WindowMus associated with |window|.
@@ -65,14 +65,7 @@ class AURA_EXPORT WindowMus {
Id server_id() const { return server_id_; }
- // Top level windows may have a root window with no associated server window.
- // This happens because the client creates the top level window first, and
- // then the WindowTreeHost. Each WindowTreeHost has a Window, so the
- // WindowTreeHost for top-levels has no server window.
- bool has_server_window() const { return server_id() != kInvalidServerId; }
-
- // See constructor for details.
- bool create_remote_window() const { return create_remote_window_; }
+ WindowMusType window_mus_type() const { return window_mus_type_; }
virtual Window* GetWindow() = 0;
@@ -118,7 +111,7 @@ class AURA_EXPORT WindowMus {
void set_server_id(Id id) { server_id_ = id; }
Id server_id_ = kInvalidServerId;
- const bool create_remote_window_;
+ const WindowMusType window_mus_type_;
};
} // namespace aura

Powered by Google App Engine
This is Rietveld 408576698