Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(825)

Unified Diff: components/sync/model/simple_metadata_change_list.cc

Issue 2470953002: [Sync] Adding a passthrough MetadataChangeList implementation. (Closed)
Patch Set: Last update for Max. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/model/simple_metadata_change_list.cc
diff --git a/components/sync/model/simple_metadata_change_list.cc b/components/sync/model/simple_metadata_change_list.cc
index e8f563d21e1a67e064934885a054a51d00b3043d..315e39c4085b072f947e6a707db3fd4c89be5040 100644
--- a/components/sync/model/simple_metadata_change_list.cc
+++ b/components/sync/model/simple_metadata_change_list.cc
@@ -20,13 +20,13 @@ void SimpleMetadataChangeList::ClearModelTypeState() {
}
void SimpleMetadataChangeList::UpdateMetadata(
- const std::string& client_tag,
+ const std::string& storage_key,
const sync_pb::EntityMetadata& metadata) {
- metadata_changes_[client_tag] = {UPDATE, metadata};
+ metadata_changes_[storage_key] = {UPDATE, metadata};
}
-void SimpleMetadataChangeList::ClearMetadata(const std::string& client_tag) {
- metadata_changes_[client_tag] = {CLEAR, sync_pb::EntityMetadata()};
+void SimpleMetadataChangeList::ClearMetadata(const std::string& storage_key) {
+ metadata_changes_[storage_key] = {CLEAR, sync_pb::EntityMetadata()};
}
const SimpleMetadataChangeList::MetadataChanges&
@@ -49,15 +49,15 @@ void SimpleMetadataChangeList::TransferChanges(
DCHECK(write_batch);
DCHECK(store);
for (const auto& pair : metadata_changes_) {
- const std::string& key = pair.first;
+ const std::string& storage_key = pair.first;
const MetadataChange& change = pair.second;
switch (change.type) {
case UPDATE:
- store->WriteMetadata(write_batch, key,
+ store->WriteMetadata(write_batch, storage_key,
change.metadata.SerializeAsString());
break;
case CLEAR:
- store->DeleteMetadata(write_batch, key);
+ store->DeleteMetadata(write_batch, storage_key);
break;
}
}
« no previous file with comments | « components/sync/model/simple_metadata_change_list.h ('k') | components/sync/model/simple_metadata_change_list_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698