components/ui_devtools/devtools_server.cc - Issue 2470933002: Disable agents when client disconnects

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ui_devtools/devtools_server.cc

Issue 2470933002: Disable agents when client disconnects (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ui_devtools/devtools_server.cc

diff --git a/components/ui_devtools/devtools_server.cc b/components/ui_devtools/devtools_server.cc

index 6fe69843e3bebaefdf7a4926f802a159c561f71d..6d7776b68f275738a3a0af90125ab59d37cb8a11 100644

--- a/components/ui_devtools/devtools_server.cc

+++ b/components/ui_devtools/devtools_server.cc

@@ -161,6 +161,7 @@ void UiDevToolsServer::OnClose(int connection_id) {

return;

UiDevToolsClient* client = it->second;

DCHECK(client);

+ client->DisableAllAgents();

client->set_connection_id(UiDevToolsClient::kNotConnected);

sadrul 2016/11/02 01:45:39 Would it make sense to combine these two into a si

Sarmad Hashmi 2016/11/02 02:43:53 Great idea! Done.

connections_.erase(it);

}