Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java

Issue 2470913009: 📰 Refactor SuggestionsSection change detection (Closed)
Patch Set: address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
index 788aa7f6f55b0bd031b8a82ef5e9c0766a16542f..a031edf5b6aea659d278194086547c6a294a3b12 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/ProgressItem.java
@@ -10,8 +10,10 @@
*
* @see ProgressViewHolder
*/
-class ProgressItem extends Leaf {
- private boolean mVisible = false;
+class ProgressItem extends OptionalLeaf {
+ protected ProgressItem(NodeParent parent) {
+ super(parent);
+ }
@Override
@ItemViewType
@@ -19,14 +21,6 @@ protected int getItemViewType() {
return ItemViewType.PROGRESS;
}
- public boolean isVisible() {
- return mVisible;
- }
-
- public void setVisible(boolean visible) {
- mVisible = visible;
- }
-
@Override
protected void onBindViewHolder(NewTabPageViewHolder holder) {
assert holder instanceof ProgressViewHolder;

Powered by Google App Engine
This is Rietveld 408576698