blimp/client/public/blimp_client_context.h - Issue 2470913005: Fix the blimp settings crash.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/public/blimp_client_context.h

Issue 2470913005: Fix the blimp settings crash. (Closed)

Patch Set: Put init code into SetDelegate. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: blimp/client/public/blimp_client_context.h

diff --git a/blimp/client/public/blimp_client_context.h b/blimp/client/public/blimp_client_context.h

index 8bf3c4a27c7312c05d0089944ce9e26caa6a18a6..d3462f600fef4b263ad09bdcc4c0ce781ed138c3 100644

--- a/blimp/client/public/blimp_client_context.h

+++ b/blimp/client/public/blimp_client_context.h

@@ -66,6 +66,7 @@ class BlimpClientContext : public KeyedService {

static void ApplyBlimpSwitches(CommandLinePrefStore* store);

// The delegate provides all the required functionality from the embedder.

+ // We must call SetDelegate right after the constructor.

Khushal 2016/11/03 00:17:24 nit: The context must be initialized with a |deleg

nyquist 2016/11/03 00:21:40 Should this also be mentioned in the constructor c

Khushal 2016/11/03 00:25:51 That makes sense. In fact mentioning it there shou

xingliu 2016/11/03 00:33:31 Done.

virtual void SetDelegate(BlimpClientContextDelegate* delegate) = 0;

// Creates a new BlimpContents that will be shown in |window|.