Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Side by Side Diff: blimp/client/core/context/blimp_client_context_impl.h

Issue 2470913005: Fix the blimp settings crash. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_ 5 #ifndef BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_
6 #define BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_ 6 #define BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 #include <string> 9 #include <string>
10 #include <unordered_map> 10 #include <unordered_map>
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 virtual void OnAssignmentReceived(AssignmentRequestResult result, 84 virtual void OnAssignmentReceived(AssignmentRequestResult result,
85 const Assignment& assignment); 85 const Assignment& assignment);
86 86
87 void RegisterFeatures(); 87 void RegisterFeatures();
88 void InitializeSettings(); 88 void InitializeSettings();
89 89
90 // Terminates the active connection held by |net_connections_|. 90 // Terminates the active connection held by |net_connections_|.
91 // May be called on any thread. 91 // May be called on any thread.
92 void DropConnection(); 92 void DropConnection();
93 93
94 // Create the |assignment_fetcher_|.
95 void CreateAssignmentFetcher();
nyquist 2016/11/02 21:30:08 CreateAssignmentFetcherIfNeeded?
xingliu 2016/11/02 23:26:52 Done.
96
94 // BlobImageSerializationProcessor::ErrorDelegate implementation. 97 // BlobImageSerializationProcessor::ErrorDelegate implementation.
95 void OnImageDecodeError() override; 98 void OnImageDecodeError() override;
96 99
97 // NetworkEventObserver implementation. 100 // NetworkEventObserver implementation.
98 void OnConnected() override; 101 void OnConnected() override;
99 void OnDisconnected(int result) override; 102 void OnDisconnected(int result) override;
100 103
101 // Provides functionality from the embedder. 104 // Provides functionality from the embedder.
102 BlimpClientContextDelegate* delegate_ = nullptr; 105 BlimpClientContextDelegate* delegate_ = nullptr;
103 106
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 141
139 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_; 142 base::WeakPtrFactory<BlimpClientContextImpl> weak_factory_;
140 143
141 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl); 144 DISALLOW_COPY_AND_ASSIGN(BlimpClientContextImpl);
142 }; 145 };
143 146
144 } // namespace client 147 } // namespace client
145 } // namespace blimp 148 } // namespace blimp
146 149
147 #endif // BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_ 150 #endif // BLIMP_CLIENT_CORE_CONTEXT_BLIMP_CLIENT_CONTEXT_IMPL_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698