Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: components/cronet/stale_host_resolver.cc

Issue 2470913003: cronet: Fix StaleHostResolver.AddressListDelta histogram. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/cronet/stale_host_resolver.cc
diff --git a/components/cronet/stale_host_resolver.cc b/components/cronet/stale_host_resolver.cc
index edf011344e3abc0b2d9b843e8d04eda0a0c8ec85..7ef542ed6587fd74869ed40a718eecc73e1f62b7 100644
--- a/components/cronet/stale_host_resolver.cc
+++ b/components/cronet/stale_host_resolver.cc
@@ -298,10 +298,8 @@ int StaleHostResolver::RequestImpl::HandleResult(int rv,
net::AddressList* addresses) {
xunjieli 2016/11/01 21:14:16 Can we change the argument from pointer to const r
Julia Tuttle 2016/11/02 16:33:41 Done.
DCHECK(result_addresses_);
- if (rv == net::OK) {
+ if (rv == net::OK)
*result_addresses_ = *addresses;
- addresses->clear();
- }
result_addresses_ = nullptr;
return rv;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698