Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2470913003:
cronet: Fix StaleHostResolver.AddressListDelta histogram. (Closed)
|
Created:
4 years, 1 month ago by Julia Tuttle Modified:
4 years, 1 month ago Reviewers:
xunjieli CC:
chromium-reviews, cbentzel+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptioncronet: Fix StaleHostResolver.AddressListDelta histogram.
BUG=661299
Committed: https://crrev.com/75863c4176f633730b0388893f46ccafaad4cc88
Cr-Commit-Position: refs/heads/master@{#429659}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Make requested change. #Messages
Total messages: 18 (11 generated)
The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run
juliatuttle@chromium.org changed reviewers: + xunjieli@chromium.org
PTAL, xunjieli.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2470913003/diff/1/components/cronet/stale_hos... File components/cronet/stale_host_resolver.cc (right): https://codereview.chromium.org/2470913003/diff/1/components/cronet/stale_hos... components/cronet/stale_host_resolver.cc:298: net::AddressList* addresses) { Can we change the argument from pointer to const ref? same for ReturnResult().
The CQ bit was checked by juliatuttle@chromium.org to run a CQ dry run
PTAL, xunjieli. https://codereview.chromium.org/2470913003/diff/1/components/cronet/stale_hos... File components/cronet/stale_host_resolver.cc (right): https://codereview.chromium.org/2470913003/diff/1/components/cronet/stale_hos... components/cronet/stale_host_resolver.cc:298: net::AddressList* addresses) { On 2016/11/01 21:14:16, xunjieli wrote: > Can we change the argument from pointer to const ref? > same for ReturnResult(). > Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by juliatuttle@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== cronet: Fix StaleHostResolver.AddressListDelta histogram. BUG=661299 ========== to ========== cronet: Fix StaleHostResolver.AddressListDelta histogram. BUG=661299 Committed: https://crrev.com/75863c4176f633730b0388893f46ccafaad4cc88 Cr-Commit-Position: refs/heads/master@{#429659} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/75863c4176f633730b0388893f46ccafaad4cc88 Cr-Commit-Position: refs/heads/master@{#429659} |
