Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java

Issue 2470903002: Add default implementation of experimental methods (Closed)
Patch Set: Addressed Paul's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
diff --git a/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
index eab6c84ae3f66587e3ffd9a1a903cc25cabcdaf2..7056dc530a266e665c46c66fc21c33bd89fd9a65 100644
--- a/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
+++ b/components/cronet/android/java/src/org/chromium/net/impl/JavaCronetEngine.java
@@ -8,12 +8,10 @@ import static android.os.Process.THREAD_PRIORITY_BACKGROUND;
import static android.os.Process.THREAD_PRIORITY_MORE_FAVORABLE;
import org.chromium.net.BidirectionalStream;
-import org.chromium.net.EffectiveConnectionType;
import org.chromium.net.ExperimentalBidirectionalStream;
import org.chromium.net.NetworkQualityRttListener;
import org.chromium.net.NetworkQualityThroughputListener;
import org.chromium.net.RequestFinishedInfo;
-import org.chromium.net.RttThroughputValues;
import org.chromium.net.UrlRequest;
import java.io.IOException;
@@ -120,22 +118,22 @@ public final class JavaCronetEngine extends CronetEngineBase {
@Override
public int getEffectiveConnectionType() {
- return EffectiveConnectionType.TYPE_UNKNOWN;
+ return EFFECTIVE_CONNECTION_TYPE_UNKNOWN;
}
@Override
public int getHttpRttMs() {
- return RttThroughputValues.INVALID_RTT_THROUGHPUT;
+ return CONNECTION_METRIC_UNKNOWN;
}
@Override
public int getTransportRttMs() {
- return RttThroughputValues.INVALID_RTT_THROUGHPUT;
+ return CONNECTION_METRIC_UNKNOWN;
}
@Override
public int getDownstreamThroughputKbps() {
- return RttThroughputValues.INVALID_RTT_THROUGHPUT;
+ return CONNECTION_METRIC_UNKNOWN;
}
@Override

Powered by Google App Engine
This is Rietveld 408576698