Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 2470863002: Generate more type information to make strong mode happy (Closed)

Created:
4 years, 1 month ago by Brian Wilkerson
Modified:
4 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Generate more type information to make strong mode happy R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/15663c61482e97807ba7828ca1cd1cef590894bf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -189 lines) Patch
M pkg/analysis_server/lib/plugin/protocol/generated_protocol.dart View 25 chunks +188 lines, -188 lines 0 comments Download
M pkg/analysis_server/tool/spec/codegen_dart_protocol.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/tool/spec/generate_files View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
4 years, 1 month ago (2016-11-01 18:08:05 UTC) #2
scheglov
LGTM
4 years, 1 month ago (2016-11-01 18:10:22 UTC) #3
Brian Wilkerson
4 years, 1 month ago (2016-11-01 18:20:49 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
15663c61482e97807ba7828ca1cd1cef590894bf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698