Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 2470853003: Printing: Disable rendering text with GDI. (Closed)

Created:
4 years, 1 month ago by Lei Zhang
Modified:
4 years, 1 month ago
Reviewers:
scottmg
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Printing: Disable rendering text with GDI. This reverts Windows printing back to the behavior in Chrome 53: - Print spool sizes are larger - But hey, no random missing characters BUG=409472, 658606 Committed: https://crrev.com/b97fbe89d9cd468834492cc1d21d5b05359eee7c Cr-Commit-Position: refs/heads/master@{#429177}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M chrome/browser/printing/print_view_manager_base.cc View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Lei Zhang
:-[
4 years, 1 month ago (2016-11-01 23:27:45 UTC) #4
scottmg
sad panda lgtm
4 years, 1 month ago (2016-11-01 23:36:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470853003/1
4 years, 1 month ago (2016-11-02 00:00:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/254490)
4 years, 1 month ago (2016-11-02 00:16:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470853003/1
4 years, 1 month ago (2016-11-02 00:46:12 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 01:25:55 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 01:28:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b97fbe89d9cd468834492cc1d21d5b05359eee7c
Cr-Commit-Position: refs/heads/master@{#429177}

Powered by Google App Engine
This is Rietveld 408576698