arc: Implement ArcContentFileSystemFileStreamReader::Read/GetLength

chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc

Index: chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
diff --git a/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ced9d9937d23f9901821e714472341e340f3b6fb
--- /dev/null
+++ b/chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader_unittest.cc
@@ -0,0 +1,124 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/files/file_util.h"
+#include "base/files/scoped_temp_dir.h"
+#include "base/location.h"
+#include "base/threading/thread_task_runner_handle.h"
+#include "chrome/browser/chromeos/arc/fileapi/arc_content_file_system_file_stream_reader.h"
+#include "components/arc/test/fake_arc_bridge_service.h"
+#include "components/arc/test/fake_intent_helper_instance.h"
+#include "content/public/test/test_browser_thread_bundle.h"
+#include "mojo/edk/embedder/embedder.h"
+#include "net/base/io_buffer.h"
+#include "net/base/test_completion_callback.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace arc {
+
+namespace {
+
+const char kArcUrl[] = "content://org.chromium.foo/bar";
+const char kData[] = "abcdefghijklmnopqrstuvwxyz";
+
+class ArcIntentHelperInstanceTestImpl : public FakeIntentHelperInstance {
+ public:
+  explicit ArcIntentHelperInstanceTestImpl(const base::FilePath& file_path)
+      : file_path_(file_path) {}
+
+  ~ArcIntentHelperInstanceTestImpl() override = default;
+
+  void GetFileSize(const mojo::String& url,
+                   const GetFileSizeCallback& callback) override {
+    EXPECT_EQ(kArcUrl, url.get());
+    base::File::Info info;
+    EXPECT_TRUE(base::GetFileInfo(file_path_, &info));
+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE, base::Bind(callback, info.size));
+  }
+
+  void OpenFileToRead(const mojo::String& url,
+                      const OpenFileToReadCallback& callback) override {
+    EXPECT_EQ(kArcUrl, url.get());
+
+    base::File file(file_path_, base::File::FLAG_OPEN | base::File::FLAG_READ);
+    EXPECT_TRUE(file.IsValid());
+
+    mojo::edk::ScopedPlatformHandle platform_handle(
+        mojo::edk::PlatformHandle(file.TakePlatformFile()));
+    MojoHandle wrapped_handle;
+    EXPECT_EQ(MOJO_RESULT_OK, mojo::edk::CreatePlatformHandleWrapper(
+                                  std::move(platform_handle), &wrapped_handle));
+
+    mojo::ScopedHandle scoped_handle{mojo::Handle(wrapped_handle)};

[hidehiko, 2016/11/10 07:07:06]

Can braces be replaced by parens?

[hashimoto, 2016/11/11 22:30:17]

Parens would make this into a form of "A a(B(c));", and we'd be bitten by most
vexing parse.

[hidehiko, 2016/11/14 17:46:34]

Oops... I understood. Thank you for explanation.

+    base::ThreadTaskRunnerHandle::Get()->PostTask(
+        FROM_HERE,
+        base::Bind(callback, base::Passed(std::move(scoped_handle))));
+  }
+
+ private:
+  base::FilePath file_path_;
+
+  DISALLOW_COPY_AND_ASSIGN(ArcIntentHelperInstanceTestImpl);
+};
+
+class ArcContentFileSystemFileStreamReaderTest : public testing::Test {
+ public:
+  ArcContentFileSystemFileStreamReaderTest() = default;
+
+  ~ArcContentFileSystemFileStreamReaderTest() override = default;
+
+  void SetUp() override {
+    mojo::edk::Init();
+
+    ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
+
+    base::FilePath path = temp_dir_.GetPath().AppendASCII("bar");
+    ASSERT_TRUE(base::WriteFile(path, kData, arraysize(kData)));
+
+    intent_helper_.reset(new ArcIntentHelperInstanceTestImpl(path));
+
+    fake_arc_bridge_service_.intent_helper()->SetInstance(intent_helper_.get());
+  }
+
+ private:
+  base::ScopedTempDir temp_dir_;
+  content::TestBrowserThreadBundle thread_bundle_;
+  FakeArcBridgeService fake_arc_bridge_service_;
+  std::unique_ptr<ArcIntentHelperInstanceTestImpl> intent_helper_;
+
+  DISALLOW_COPY_AND_ASSIGN(ArcContentFileSystemFileStreamReaderTest);
+};
+
+}  // namespace
+
+TEST_F(ArcContentFileSystemFileStreamReaderTest, Read) {
+  ArcContentFileSystemFileStreamReader reader(GURL(kArcUrl), 0);
+
+  auto base_buffer =
+      make_scoped_refptr(new net::IOBufferWithSize(arraysize(kData)));
+  auto drainable_buffer = make_scoped_refptr(
+      new net::DrainableIOBuffer(base_buffer.get(), base_buffer->size()));
+  while (drainable_buffer->BytesRemaining()) {
+    net::TestCompletionCallback callback;
+    int result = callback.GetResult(
+        reader.Read(drainable_buffer.get(), drainable_buffer->BytesRemaining(),
+                    callback.callback()));
+    ASSERT_GT(result, 0);
+    drainable_buffer->DidConsume(result);
+  }
+  EXPECT_EQ(std::string(kData, kData + arraysize(kData)),

[hidehiko, 2016/11/10 07:07:06]

Optional: How about comparing by StringPiece?

[hashimoto, 2016/11/11 22:30:17]

Done.

+            std::string(base_buffer->data(),
+                        base_buffer->data() + base_buffer->size()));
+}
+
+TEST_F(ArcContentFileSystemFileStreamReaderTest, GetLength) {
+  ArcContentFileSystemFileStreamReader reader(GURL(kArcUrl), 0);
+
+  net::TestInt64CompletionCallback callback;
+  EXPECT_EQ(static_cast<int64_t>(arraysize(kData)),
+            callback.GetResult(reader.GetLength(callback.callback())));
+}
+
+}  // namespace arc