Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc

Issue 2470833002: Fix WRITING_MODE_IGNORED's comment in NGFragment::MarginStrut (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc b/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
index 6c5cdbd5b51040294b9c17d231aab4a1daf5d3d7..9ccb19c283e5d3dcdca3bf3a0ea477a19439d410 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_fragment.cc
@@ -11,8 +11,9 @@ namespace blink {
NGMarginStrut NGFragment::MarginStrut() const {
WRITING_MODE_IGNORED(
- "Accessing the margin strut ignoring the writing mode here is fine."
- "A margin strut is never set for a fragment");
+ "Accessing the margin strut is fine here. Changing the writing mode"
+ "establishes a new formatting context, for which a margin strut is never"
+ "set for a fragment.");
return toNGPhysicalFragment(physical_fragment_)->MarginStrut();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698