Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2470833002: Fix WRITING_MODE_IGNORED's comment in NGFragment::MarginStrut (Closed)

Created:
4 years, 1 month ago by Gleb Lanbin
Modified:
4 years, 1 month ago
Reviewers:
cbiesinger, ikilpatrick
CC:
chromium-reviews, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix WRITING_MODE_IGNORED's comment in NGFragment::MarginStrut BUG=635619 Committed: https://crrev.com/8b9144a314b0cd585fbca0359214a7b2f9dd3480 Cr-Commit-Position: refs/heads/master@{#429068}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_fragment.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Gleb Lanbin
4 years, 1 month ago (2016-11-01 17:07:08 UTC) #3
cbiesinger
lgtm
4 years, 1 month ago (2016-11-01 17:14:57 UTC) #6
ikilpatrick
lgtm
4 years, 1 month ago (2016-11-01 17:35:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470833002/20001
4 years, 1 month ago (2016-11-01 19:10:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-01 19:15:23 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 19:29:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b9144a314b0cd585fbca0359214a7b2f9dd3480
Cr-Commit-Position: refs/heads/master@{#429068}

Powered by Google App Engine
This is Rietveld 408576698