Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 247083003: Revert "Make scrubbing a MediaControls-internal concept" (Closed)

Created:
6 years, 8 months ago by philipj_slow
Modified:
6 years, 8 months ago
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, ojan
Visibility:
Public.

Description

Revert "Make scrubbing a MediaControls-internal concept" This reverts r169814. BUG=341813, 359522

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -18 lines) Patch
M LayoutTests/media/controls-drag-timebar.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/media/controls-drag-timebar-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLMediaElement.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/html/MediaController.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/MediaController.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/core/html/shadow/MediaControls.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/MediaControls.cpp View 3 chunks +8 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
philipj_slow
6 years, 8 months ago (2014-04-22 13:39:33 UTC) #1
acolwell GONE FROM CHROMIUM
lgtm
6 years, 8 months ago (2014-04-22 17:41:42 UTC) #2
philipj_slow
The CQ bit was checked by philipj@opera.com
6 years, 8 months ago (2014-04-22 20:15:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/247083003/1
6 years, 8 months ago (2014-04-22 20:15:56 UTC) #4
philipj_slow
6 years, 8 months ago (2014-04-22 21:18:53 UTC) #5
The CQ bit was unchecked by philipj@opera.com

Powered by Google App Engine
This is Rietveld 408576698