Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(583)

Issue 247073002: Version 3.25.28.14 (partial merge of r20839) (Closed)

Created:
6 years, 8 months ago by danno
Modified:
6 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Version 3.25.28.14 (partial merge of r20839) Fix Object.observe() notifications from Array.push()/Array.pop() R=mstarzinger@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20906

Patch Set 1 #

Patch Set 2 : Add missing test case #

Patch Set 3 : Bump version number #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M src/hydrogen.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/version.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A test/mjsunit/array-push7.js View 1 1 chunk +59 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
danno
6 years, 8 months ago (2014-04-22 08:54:32 UTC) #1
Michael Starzinger
LGTM (rubber-stamped).
6 years, 8 months ago (2014-04-22 08:56:17 UTC) #2
danno
6 years, 8 months ago (2014-04-23 12:20:03 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r20906 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698