Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2082)

Unified Diff: chrome/browser/ui/app_list/app_list_service_unittest.cc

Issue 24707002: Add unit tests for AppListServiceImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: un-const an iterator Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/app_list_service_unittest.cc
diff --git a/chrome/browser/ui/app_list/app_list_service_unittest.cc b/chrome/browser/ui/app_list/app_list_service_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..ce41574a25c658f7bd2c7c38c29bd15dbeed28a9
--- /dev/null
+++ b/chrome/browser/ui/app_list/app_list_service_unittest.cc
@@ -0,0 +1,178 @@
+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "apps/pref_names.h"
+#include "apps/prefs.h"
+#include "base/command_line.h"
+#include "base/files/file_path.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/prefs/pref_registry_simple.h"
+#include "base/prefs/pref_service.h"
+#include "base/prefs/pref_service_builder.h"
+#include "base/prefs/testing_pref_store.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profiles_state.h"
+#include "chrome/browser/ui/app_list/app_list_service.h"
+#include "chrome/browser/ui/app_list/app_list_service_impl.h"
+#include "chrome/browser/ui/app_list/test/fake_keep_alive_service.h"
+#include "chrome/browser/ui/app_list/test/fake_profile.h"
+#include "chrome/browser/ui/app_list/test/fake_profile_store.h"
+#include "chrome/common/chrome_constants.h"
+#include "chrome/common/chrome_switches.h"
+#include "chrome/common/pref_names.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+class TestingAppListServiceImpl : public AppListServiceImpl {
+ public:
+ TestingAppListServiceImpl(const CommandLine& command_line,
+ PrefService* local_state,
+ scoped_ptr<ProfileStore> profile_store,
+ scoped_ptr<KeepAliveService> keep_alive_service)
+ : AppListServiceImpl(command_line,
+ local_state,
+ profile_store.Pass(),
+ keep_alive_service.Pass()),
+ showing_for_profile_(NULL) {
+ }
+
+ Profile* showing_for_profile() const {
+ return showing_for_profile_;
+ }
+
+ void HandleCommandLineFlags(Profile* profile) {
+ AppListServiceImpl::HandleCommandLineFlags(profile);
+ }
+
+ virtual void CreateForProfile(Profile* requested_profile) OVERRIDE {
+ }
+
+ virtual void ShowForProfile(Profile* requested_profile) OVERRIDE {
+ showing_for_profile_ = requested_profile;
+ }
+
+ virtual void DismissAppList() OVERRIDE {
+ showing_for_profile_ = NULL;
+ }
+
+ virtual bool IsAppListVisible() const OVERRIDE {
+ return !!showing_for_profile_;
+ }
+
+ virtual gfx::NativeWindow GetAppListWindow() OVERRIDE {
+ return NULL;
+ }
+
+ virtual AppListControllerDelegate* CreateControllerDelegate() OVERRIDE {
+ return NULL;
+ }
+
+ private:
+ Profile* showing_for_profile_;
+};
+
+class AppListServiceUnitTest : public testing::Test {
+ public:
+ virtual void SetUp() OVERRIDE {
+ SetupWithCommandLine(CommandLine(CommandLine::NO_PROGRAM));
+ }
+
+ void SetupWithCommandLine(const CommandLine& command_line) {
+ user_data_dir_ = base::FilePath(FILE_PATH_LITERAL("udd"));
+ profile1_.reset(
+ new FakeProfile("p1", user_data_dir_.AppendASCII("profile1")));
+ profile2_.reset(
+ new FakeProfile("p2", user_data_dir_.AppendASCII("profile2")));
+ PrefRegistrySimple* pref_registry = new PrefRegistrySimple;
+
+ AppListService::RegisterPrefs(pref_registry);
+ apps::RegisterPrefs(pref_registry);
+ profiles::RegisterPrefs(pref_registry);
+
+ PrefServiceBuilder builder;
+ builder.WithUserPrefs(new TestingPrefStore);
+ local_state_.reset(builder.Create(pref_registry));
+
+ keep_alive_service_ = new FakeKeepAliveService;
+ profile_store_ = new FakeProfileStore(user_data_dir_);
+ service_.reset(new TestingAppListServiceImpl(
+ command_line,
+ local_state_.get(),
+ scoped_ptr<ProfileStore>(profile_store_),
+ scoped_ptr<KeepAliveService>(keep_alive_service_)));
+ }
+
+ base::FilePath user_data_dir_;
+ scoped_ptr<PrefService> local_state_;
+ FakeProfileStore* profile_store_;
+ FakeKeepAliveService* keep_alive_service_;
+ scoped_ptr<TestingAppListServiceImpl> service_;
+ scoped_ptr<FakeProfile> profile1_;
+ scoped_ptr<FakeProfile> profile2_;
+};
+
+TEST_F(AppListServiceUnitTest, EnablingStateIsPersisted) {
+ EXPECT_FALSE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
+ service_->EnableAppList(profile1_.get());
+ EXPECT_TRUE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
+ EXPECT_EQ(profile1_->GetPath(), user_data_dir_.Append(
+ local_state_->GetFilePath(prefs::kAppListProfile)));
+}
+
+TEST_F(AppListServiceUnitTest, ShowingForProfileLoadsAProfile) {
+ profile_store_->LoadProfile(profile1_.get());
+ service_->EnableAppList(profile1_.get());
+ service_->Show();
+ EXPECT_EQ(profile1_.get(), service_->showing_for_profile());
+ EXPECT_TRUE(service_->IsAppListVisible());
+}
+
+TEST_F(AppListServiceUnitTest, RemovedProfileResetsToInitialProfile) {
+ service_->EnableAppList(profile1_.get());
+ profile_store_->RemoveProfile(profile1_.get());
+ base::FilePath initial_profile_path =
+ user_data_dir_.AppendASCII(chrome::kInitialProfile);
+ EXPECT_EQ(initial_profile_path,
+ service_->GetProfilePath(profile_store_->GetUserDataDir()));
+}
+
+TEST_F(AppListServiceUnitTest,
+ RemovedProfileResetsToLastUsedProfileIfExists) {
+ local_state_->SetString(prefs::kProfileLastUsed, "last-used");
+ service_->EnableAppList(profile1_.get());
+ profile_store_->RemoveProfile(profile1_.get());
+ base::FilePath last_used_profile_path =
+ user_data_dir_.AppendASCII("last-used");
+ EXPECT_EQ(last_used_profile_path,
+ service_->GetProfilePath(profile_store_->GetUserDataDir()));
+}
+
+TEST_F(AppListServiceUnitTest, SwitchingProfilesPersists) {
+ profile_store_->LoadProfile(profile1_.get());
+ profile_store_->LoadProfile(profile2_.get());
+ service_->EnableAppList(profile1_.get());
+ service_->SetProfilePath(profile2_->GetPath());
+ service_->Show();
+ EXPECT_EQ(profile2_.get(), service_->showing_for_profile());
+ EXPECT_EQ(profile2_->GetPath(),
+ service_->GetProfilePath(profile_store_->GetUserDataDir()));
+ service_->SetProfilePath(profile1_->GetPath());
+ EXPECT_EQ(profile1_->GetPath(),
+ service_->GetProfilePath(profile_store_->GetUserDataDir()));
+}
+
+TEST_F(AppListServiceUnitTest, EnableViaCommandLineFlag) {
+ CommandLine command_line(CommandLine::NO_PROGRAM);
+ command_line.AppendSwitch(switches::kEnableAppList);
+ SetupWithCommandLine(command_line);
+ service_->HandleCommandLineFlags(profile1_.get());
+ EXPECT_TRUE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
+}
+
+TEST_F(AppListServiceUnitTest, DisableViaCommandLineFlag) {
+ CommandLine command_line(CommandLine::NO_PROGRAM);
+ command_line.AppendSwitch(switches::kDisableAppList);
+ SetupWithCommandLine(command_line);
+ service_->HandleCommandLineFlags(profile1_.get());
+ EXPECT_FALSE(local_state_->GetBoolean(prefs::kAppLauncherHasBeenEnabled));
+}
« no previous file with comments | « chrome/browser/ui/app_list/app_list_service_impl.cc ('k') | chrome/browser/ui/app_list/fast_show_pickler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698