Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7158)

Unified Diff: chrome/browser/ui/views/app_list/keep_alive_service_impl.cc

Issue 24707002: Add unit tests for AppListServiceImpl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: un-const an iterator Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/app_list/keep_alive_service_impl.cc
diff --git a/chrome/browser/ui/views/app_list/keep_alive_service_impl.cc b/chrome/browser/ui/views/app_list/keep_alive_service_impl.cc
deleted file mode 100644
index e7597cbb34ef3fe0561d70a2c8288ecb2c7046d9..0000000000000000000000000000000000000000
--- a/chrome/browser/ui/views/app_list/keep_alive_service_impl.cc
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/ui/views/app_list/keep_alive_service_impl.h"
-
-#include "base/message_loop/message_loop.h"
-#include "chrome/browser/lifetime/application_lifetime.h"
-#include "content/public/browser/browser_thread.h"
-
-ScopedKeepAlive::ScopedKeepAlive() {
- chrome::StartKeepAlive();
-}
-
-ScopedKeepAlive::~ScopedKeepAlive() {
- chrome::EndKeepAlive();
-}
-
-KeepAliveServiceImpl::KeepAliveServiceImpl() {
-}
-
-KeepAliveServiceImpl::~KeepAliveServiceImpl() {
-}
-
-void KeepAliveServiceImpl::EnsureKeepAlive() {
- if (!keep_alive_)
- keep_alive_.reset(new ScopedKeepAlive());
-}
-
-void KeepAliveServiceImpl::FreeKeepAlive() {
- if (keep_alive_) {
- // We may end up here as the result of the OS deleting the AppList's
- // widget (WidgetObserver::OnWidgetDestroyed). If this happens and there
- // are no browsers around then deleting the keep alive will result in
- // deleting the Widget again (by way of CloseAllSecondaryWidgets). When
- // the stack unravels we end up back in the Widget that was deleted and
- // crash. By delaying deletion of the keep alive we ensure the Widget has
- // correctly been destroyed before ending the keep alive so that
- // CloseAllSecondaryWidgets() won't attempt to delete the AppList's Widget
- // again.
- base::MessageLoop::current()->DeleteSoon(FROM_HERE,
- keep_alive_.release());
- }
-}

Powered by Google App Engine
This is Rietveld 408576698