Add unit tests for AppListServiceImpl.

chrome/browser/ui/app_list/profile_loader.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef CHROME_BROWSER_PROFILES_PROFILE_LOADER_H_
-#define CHROME_BROWSER_PROFILES_PROFILE_LOADER_H_
+#ifndef CHROME_BROWSER_UI_APP_LIST_PROFILE_LOADER_H_
+#define CHROME_BROWSER_UI_APP_LIST_PROFILE_LOADER_H_
 
 #include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/app_list/keep_alive_service.h"
+#include "chrome/browser/ui/app_list/profile_store.h"
 
 namespace base {
 class FilePath;
 }
 
 class ProfileManager;
 
 // This class loads profiles asynchronously and calls the provided callback once
 // the profile is ready. Only the callback for the most recent load request is
 // called, and only if the load was successful.
 //
 // This is useful for loading profiles in response to user interaction where

[benwells, 2013/09/26 06:55:29]

Please add a TODO to remove this class and fold it into AppListServiceImpl, or
just do it.

[koz (OOO until 15th September), 2013/09/26 22:12:47]

Added TODO.

 // only the latest requested profile is required.
 class ProfileLoader {
  public:
-  explicit ProfileLoader(ProfileManager* profile_manager);
+  explicit ProfileLoader(ProfileStore* profile_store,
+                         scoped_ptr<KeepAliveService> keep_alive_service);
   ~ProfileLoader();
 
   bool IsAnyProfileLoading() const;
   void InvalidatePendingProfileLoads();
   void LoadProfileInvalidatingOtherLoads(
       const base::FilePath& profile_file_path,
       base::Callback<void(Profile*)> callback);
 
- protected:
-  // These just call through to the ProfileManager.
-  // Virtual so they can be mocked out in tests.
-  virtual Profile* GetProfileByPath(const base::FilePath& path);
-  virtual void CreateProfileAsync(
-      const base::FilePath& profile_path,
-      const ProfileManager::CreateCallback& callback,
-      const string16& name,
-      const string16& icon_url,
-      const std::string& managed_user_id);
-
  private:
   void OnProfileLoaded(int profile_load_sequence_id,
                        base::Callback<void(Profile*)> callback,
-                       Profile* profile,
-                       Profile::CreateStatus status);
+                       Profile* profile);
 
   void IncrementPendingProfileLoads();
   void DecrementPendingProfileLoads();
 
-  ProfileManager* profile_manager_;
+  ProfileStore* profile_store_;
+  scoped_ptr<KeepAliveService> keep_alive_service_;
   int profile_load_sequence_id_;
   int pending_profile_loads_;
 
   base::WeakPtrFactory<ProfileLoader> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(ProfileLoader);
 };
 
-#endif  // CHROME_BROWSER_PROFILES_PROFILE_LOADER_H_
+#endif  // CHROME_BROWSER_UI_APP_LIST_PROFILE_LOADER_H_