Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2470663006: Add .clang-format and run clang-format on runtime/platform. (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add .clang-format and run clang-format on runtime/platform. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/6953586716b58717bfec27a28bc7ec3611986022

Patch Set 1 #

Patch Set 2 : Fix .clang-format #

Patch Set 3 : Reformat based on comments #

Patch Set 4 : Remove default override for short functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+212 lines, -193 lines) Patch
A .clang-format View 1 2 3 1 chunk +16 lines, -0 lines 0 comments Download
M runtime/platform/address_sanitizer.h View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/platform/assert.h View 1 2 16 chunks +56 lines, -70 lines 0 comments Download
M runtime/platform/assert.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/platform/c99_support_win.h View 3 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/platform/floating_point.h View 3 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/platform/floating_point_win.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M runtime/platform/globals.h View 1 2 13 chunks +35 lines, -40 lines 0 comments Download
M runtime/platform/hashmap.h View 2 chunks +3 lines, -5 lines 0 comments Download
M runtime/platform/memory_sanitizer.h View 1 2 1 chunk +8 lines, -4 lines 0 comments Download
M runtime/platform/signal_blocker.h View 1 2 1 chunk +33 lines, -25 lines 0 comments Download
M runtime/platform/text_buffer.h View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/platform/text_buffer.cc View 3 1 chunk +1 line, -2 lines 0 comments Download
M runtime/platform/utils.h View 7 chunks +18 lines, -23 lines 0 comments Download
M runtime/platform/utils.cc View 1 chunk +20 lines, -5 lines 0 comments Download
M runtime/platform/utils_linux.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-11-03 20:50:29 UTC) #2
Cutch
lgtm
4 years, 1 month ago (2016-11-03 20:51:06 UTC) #3
zra
4 years, 1 month ago (2016-11-03 21:25:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
6953586716b58717bfec27a28bc7ec3611986022 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698