Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 2470663003: Revert of command buffer: audit validation of ES3 commands (part 1) (Closed)

Created:
4 years, 1 month ago by please use gerrit instead
Modified:
4 years, 1 month ago
CC:
chromium-reviews, piman+watch_chromium.org, Ken Russell (switch to Gerrit)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of command buffer: audit validation of ES3 commands (part 1) (patchset #2 id:20001 of https://codereview.chromium.org/2458523005/ ) Reason for revert: Speculative revert for interacitve_ui_test flakes on mac. First failed build: https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8412 Original issue's description: > command buffer: audit validation of ES3 commands (part 1) > > Audit the validation (safety) of the first few ES3 command buffer commands - and switch the gating from 'unsafe_es3_apis_enabled()' to 'feature_info_->IsWebGL2OrES3Context' on newly audited commands. > > BUG=654787 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/6e51299d296d504fb450dcdbb1814427cd62248f > Cr-Commit-Position: refs/heads/master@{#428499} TBR=zmo@chromium.org,kainino@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=654787 Committed: https://crrev.com/c2ba95c8151deb3fcb1690e44c71c038af0a3627 Cr-Commit-Position: refs/heads/master@{#428999}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 14 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
please use gerrit instead
Created Revert of command buffer: audit validation of ES3 commands (part 1)
4 years, 1 month ago (2016-11-01 13:40:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470663003/1
4 years, 1 month ago (2016-11-01 13:41:07 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 14:28:57 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c2ba95c8151deb3fcb1690e44c71c038af0a3627 Cr-Commit-Position: refs/heads/master@{#428999}
4 years, 1 month ago (2016-11-01 14:32:46 UTC) #7
please use gerrit instead
7 builds without a failure. This revert may have fixed the flake.
4 years, 1 month ago (2016-11-01 16:13:40 UTC) #8
please use gerrit instead
4 years, 1 month ago (2016-11-01 17:08:25 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2465333002/ by rouslan@chromium.org.

The reason for reverting is: The revert did not fix the interacitve_ui_test
flake.

Failed build after the revert:
https://build.chromium.org/p/chromium.mac/builders/Mac10.10%20Tests/builds/8542.

Powered by Google App Engine
This is Rietveld 408576698