Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2470643002: Allow raw string literals and add a sample usage. (Closed)

Created:
4 years, 1 month ago by Peter Kasting
Modified:
4 years, 1 month ago
Reviewers:
Nico, brettw
CC:
chromium-reviews, Dirk Pranke, danakj+watch_chromium.org, jbroman+cpp_chromium.org, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow raw string literals and add a sample usage. This was tentatively approved on the discussion thread two months ago. BUG=none TEST=none Committed: https://crrev.com/bf8b8103771747ed31d3af4e924de7cd27607deb Cr-Commit-Position: refs/heads/master@{#429402}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Resync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -57 lines) Patch
M styleguide/c++/c++11.html View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/args.cc View 1 chunk +57 lines, -56 lines 0 comments Download

Depends on Patchset:

Issue 2466103002 Patch 20001

Messages

Total messages: 16 (8 generated)
Peter Kasting
brettw: tools/gn (P.S. I am hoping to win brownie points from you for this) thakis: ...
4 years, 1 month ago (2016-11-01 01:13:29 UTC) #2
Nico
lgtm! https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (left): https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html#oldcode1 styleguide/c++/c++11.html:1: <!DOCTYPE html> what changed here?
4 years, 1 month ago (2016-11-01 01:20:47 UTC) #3
Peter Kasting
https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html File styleguide/c++/c++11.html (left): https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html#oldcode1 styleguide/c++/c++11.html:1: <!DOCTYPE html> On 2016/11/01 01:20:47, Nico wrote: > what ...
4 years, 1 month ago (2016-11-01 01:32:22 UTC) #4
Peter Kasting
On 2016/11/01 01:32:22, Peter Kasting wrote: > https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html > File styleguide/c++/c++11.html (left): > > https://codereview.chromium.org/2470643002/diff/1/styleguide/c++/c++11.html#oldcode1 ...
4 years, 1 month ago (2016-11-01 01:38:15 UTC) #5
brettw
Neato, LGTM
4 years, 1 month ago (2016-11-01 22:42:06 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470643002/20001
4 years, 1 month ago (2016-11-02 21:00:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 21:15:28 UTC) #14
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:19:44 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/bf8b8103771747ed31d3af4e924de7cd27607deb
Cr-Commit-Position: refs/heads/master@{#429402}

Powered by Google App Engine
This is Rietveld 408576698