Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 247063003: Handle boxed length in JSON stringify. (Closed)

Created:
6 years, 8 months ago by Jarin
Modified:
6 years, 8 months ago
Reviewers:
Toon Verwaest, Yang
CC:
v8-dev
Visibility:
Public.

Description

Handle boxed length in JSON stringify. Here is the test that used to fail in Smi::cast: JSON.stringify(new Array(4000000000)); I am not adding the test because it takes huge amount of time before it runs out of memory. R=verwaest@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=20898

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/json-stringifier.h View 5 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 8 months ago (2014-04-22 13:15:19 UTC) #1
Yang
On 2014/04/22 13:15:19, jarin wrote: lgtm.
6 years, 8 months ago (2014-04-22 15:40:50 UTC) #2
Jarin
6 years, 8 months ago (2014-04-23 08:40:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20898 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698