Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2470563002: Merged: Avoid using stale InspectedContext pointers (Closed)

Created:
4 years, 1 month ago by robwu
Modified:
4 years, 1 month ago
Reviewers:
kozy, Michael Hablich
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.5
Project:
v8
Visibility:
Public.

Description

Merged: Avoid using stale InspectedContext pointers Revision: cb2a39d36762da3a800d9b5e734319d1141070b9 BUG=chromium:657568 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=kozyatinskiy@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/inspector/injected-script.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/inspector/inspected-context.h View 1 chunk +1 line, -1 line 0 comments Download
M src/inspector/inspected-context.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M src/inspector/v8-inspector-session-impl.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
robwu
4 years, 1 month ago (2016-10-31 22:19:38 UTC) #1
robwu
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
4 years, 1 month ago (2016-10-31 22:19:40 UTC) #2
kozy
lgtm, but please wait for @hablich approval in issue for V8 merge.
4 years, 1 month ago (2016-11-01 15:02:39 UTC) #3
Michael Hablich
On 2016/11/01 15:02:39, kozyatinskiy wrote: > lgtm, but please wait for @hablich approval in issue ...
4 years, 1 month ago (2016-11-02 08:56:40 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470563002/1
4 years, 1 month ago (2016-11-02 08:56:50 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 08:57:10 UTC) #7
Message was sent while issue was closed. 
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698