Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 2470553002: Remove no-op SSL_CTX_set_cipher_list_tls11 call. (Closed)

Created:
4 years, 1 month ago by davidben
Modified:
4 years, 1 month ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove no-op SSL_CTX_set_cipher_list_tls11 call. By configuring the same list twice, this function call doesn't do anything. This mechanism is also no longer useful and is slowly being wound down. (That API is remnant of when we had RC4. Both RC4 and CBC mode ciphers are horribly broken. For a time, whether you preferred RC4 or CBC varied depending on what version you had since the CBC mode ciphers are increasibly broken the further back you go. Now RC4 is completely gone anyway, so it's not useful. Regardless, the way Dart uses it never did anything.) BUG=none R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/62f55ee76f76e925f0ee174659a65aa2e8f7ca0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M runtime/bin/secure_socket_boringssl.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
davidben
4 years, 1 month ago (2016-10-31 21:11:14 UTC) #2
Bill Hesse
lgtm
4 years, 1 month ago (2016-10-31 23:54:53 UTC) #3
davidben
On 2016/10/31 23:54:53, Bill Hesse wrote: > lgtm (I probably don't have bits to land ...
4 years, 1 month ago (2016-10-31 23:56:57 UTC) #4
zra
4 years, 1 month ago (2016-11-02 17:05:22 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
62f55ee76f76e925f0ee174659a65aa2e8f7ca0a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698