[Devtools] Fixed dividers in new network canvas timeline

[Devtools] Fixed dividers in new network canvas timeline

Fixed dividers in network canvas timeline experiment. Before
they were not scrolling properly when the top timeline was moved.

R=dgozman
BUG=653738
Committed: https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf
Cr-Commit-Position: refs/heads/master@{#428892}

[allada, 2016-10-31 21:33:48]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-31 21:33:53]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[allada, 2016-10-31 21:34:06]

allada@chromium.org changed reviewers:
+ alph@chromium.org, caseq@chromium.org

[allada, 2016-10-31 21:34:06]

PTL

[commit-bot: I haz the power, 2016-10-31 21:34:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[caseq, 2016-10-31 21:59:45]

lgtm

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:292:
this._calculator.setDisplayWindow(this._offsetWidth);
This could probably go next to where we actually change this._offsetWidth,
perhaps to calculateCanvasSize().

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:312:
WebInspector.TimelineGrid.drawCanvasGrid(context, this._calculator,
this._fontSize, 75);
Extract a constant for 75?

[commit-bot: I haz the power, 2016-10-31 22:57:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:57:08]

Dry run: This issue passed the CQ dry run.

[allada, 2016-10-31 23:35:26]

done

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:292:
this._calculator.setDisplayWindow(this._offsetWidth);
On 2016/10/31 21:59:45, caseq wrote:
> This could probably go next to where we actually change this._offsetWidth,
> perhaps to calculateCanvasSize().

Done.

https://codereview.chromium.org/2470523003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:312:
WebInspector.TimelineGrid.drawCanvasGrid(context, this._calculator,
this._fontSize, 75);
On 2016/10/31 21:59:45, caseq wrote:
> Extract a constant for 75?

Done.

[allada, 2016-10-31 23:36:50]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-31 23:36:50]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2470523003/#ps40001
(title: "changes")

[commit-bot: I haz the power, 2016-10-31 23:37:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:39:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:39:47]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[allada, 2016-10-31 23:43:34]

Patchset #2 (id:40001) has been deleted

[allada, 2016-10-31 23:43:38]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-31 23:43:39]

The patchset sent to the CQ was uploaded after l-g-t-m from caseq@chromium.org
Link to the patchset: https://codereview.chromium.org/2470523003/#ps60001
(title: "Merge branch 'master' into NETWORK_TIMELINE_FIX_DIVIDERS")

[commit-bot: I haz the power, 2016-10-31 23:44:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 01:03:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 01:03:04]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[commit-bot: I haz the power, 2016-11-01 01:03:38]

Description was changed from

==========
[Devtools] Fixed dividers in new network canvas timeline

Fixed dividers in network canvas timeline experiment. Before
they were not scrolling properly when the top timeline was moved.

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Fixed dividers in new network canvas timeline

Fixed dividers in network canvas timeline experiment. Before
they were not scrolling properly when the top timeline was moved.

R=dgozman
BUG=653738

Committed: https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf
Cr-Commit-Position: refs/heads/master@{#428892}
==========

[commit-bot: I haz the power, 2016-11-01 01:03:39]

Patchset 2 (id:??) landed as
https://crrev.com/86f846737a09e14aafe1e40a2b7d823ade6703cf
Cr-Commit-Position: refs/heads/master@{#428892}