Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 2470503003: Media controls max width is the width of the viewport. (Closed)

Created:
4 years, 1 month ago by mlamouri (slow - plz ping)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, eric.carlson_apple.com, feature-media-reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, mlamouri+watch-blink_chromium.org, pdr+renderingwatchlist_chromium.org, Srirama, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media controls max width is the width of the viewport. When a media element can't be shown in the viewport and horizontal scrolling is blocked, the controls should take this into considerations and don't get partially hidden. BUG=637939 R=eae@chromium.org Committed: https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d Cr-Commit-Position: refs/heads/master@{#429288}

Patch Set 1 #

Patch Set 2 : w/ tests #

Total comments: 1

Patch Set 3 : dcheck #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/media/media-controls-overflow-hidden.html View 1 1 chunk +48 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/media/media-controls-overflow-visible.html View 1 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 2 5 chunks +44 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
mlamouri (slow - plz ping)
4 years, 1 month ago (2016-10-31 20:34:00 UTC) #4
eae
LGTM https://codereview.chromium.org/2470503003/diff/20001/third_party/WebKit/Source/core/layout/LayoutMedia.cpp File third_party/WebKit/Source/core/layout/LayoutMedia.cpp (right): https://codereview.chromium.org/2470503003/diff/20001/third_party/WebKit/Source/core/layout/LayoutMedia.cpp#newcode179 third_party/WebKit/Source/core/layout/LayoutMedia.cpp:179: return std::min(mediaRect.width(), visibleWidth - absoluteXOffset); Can visibleWidth - ...
4 years, 1 month ago (2016-11-01 16:56:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470503003/40001
4 years, 1 month ago (2016-11-02 14:18:49 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-02 15:53:24 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 16:20:41 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3347bb8ad251e778ed35c433c0246e0659f2402d
Cr-Commit-Position: refs/heads/master@{#429288}

Powered by Google App Engine
This is Rietveld 408576698