Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1028)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp

Issue 2470463002: Add data parameter to payment details modifier. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
index 988948ea1bc35689faf06dc53ad478585f9cabb2..0dd19df44680f66167771b7799349757f9a1ab00 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp
@@ -111,8 +111,9 @@ std::ostream& operator<<(std::ostream& out, DetailsTestCase testCase) {
switch (testCase.m_modType) {
case PaymentTestOverwriteValue:
- out << "is overwritten by ";
+ out << "is overwritten by '";
out << testCase.m_valueToUse;
+ out << "'";
break;
case PaymentTestRemoveKey:
out << "is removed";
@@ -129,9 +130,11 @@ TEST_P(PaymentRequestDetailsTest, ValidatesDetails) {
V8TestingScope scope;
scope.document().setSecurityOrigin(
SecurityOrigin::create(KURL(KURL(), "https://www.example.com/")));
- PaymentRequest::create(scope.getScriptState(),
- buildPaymentMethodDataForTest(),
- GetParam().buildDetails(), scope.getExceptionState());
+ PaymentOptions options;
+ options.setRequestShipping(true);
+ PaymentRequest::create(
+ scope.getScriptState(), buildPaymentMethodDataForTest(),
+ GetParam().buildDetails(), options, scope.getExceptionState());
EXPECT_EQ(GetParam().expectException(),
scope.getExceptionState().hadException());

Powered by Google App Engine
This is Rietveld 408576698