Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2470413005: Fix reset and focus issues in OOBE (Closed)

Created:
4 years, 1 month ago by David Tseng
Modified:
4 years, 1 month ago
Reviewers:
dmazzoni
CC:
chromium-reviews, extensions-reviews_chromium.org, alemate+watch_chromium.org, oshima+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, dmazzoni+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix reset and focus issues in OOBE - if an extension is toggled off then on, and re-requests the desktop automation tree, it might receive tree data for a child tree before the child tree's accessibility data is reset via chrome.automation.enableFrame. This results in the client extension tree having an embeddedObject node with one child with role unknown. Fix this by always resetting a child tree root that has unknown role - work around webview focus issues by explicitly always checking the ancestors we've crossed into and always focusing first embeddedObject nodes. This should be removed once webview handles propagating upwards focus from descendants correctly. BUG=660390 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/20d6d96d1e472287cb4270b1d6c8b48973994fcd Cr-Commit-Position: refs/heads/master@{#429978}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/background.js View 3 chunks +16 lines, -5 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
David Tseng
4 years, 1 month ago (2016-11-04 15:29:39 UTC) #4
dmazzoni
lgtm
4 years, 1 month ago (2016-11-04 16:47:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470413005/1
4 years, 1 month ago (2016-11-04 18:17:38 UTC) #7
commit-bot: I haz the power
Failed to apply the patch. On branch working_branch Your branch is up-to-date with 'origin/refs/pending/heads/master'. nothing ...
4 years, 1 month ago (2016-11-04 19:33:49 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 20:00:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/20d6d96d1e472287cb4270b1d6c8b48973994fcd
Cr-Commit-Position: refs/heads/master@{#429978}

Powered by Google App Engine
This is Rietveld 408576698