Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 2470383002: Add catalog_viewer to mash_packaged_service. (Closed)

Created:
4 years, 1 month ago by Hadi
Modified:
4 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add catalog_viewer to mash_packaged_service. We were getting errors when trying to run catalog_viewer from quick launch. This CL fixes that. BUG=NONE Committed: https://crrev.com/6beed581f1e7936cee213ad551116228f7f91c86 Cr-Commit-Position: refs/heads/master@{#429636}

Patch Set 1 #

Patch Set 2 : some cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/app/mash/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 chunks +2 lines, -0 lines 0 comments Download
M mash/package/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M mash/package/mash_packaged_service.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Hadi
PTAL.
4 years, 1 month ago (2016-11-03 13:54:34 UTC) #3
sky
LGTM
4 years, 1 month ago (2016-11-03 17:17:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470383002/20001
4 years, 1 month ago (2016-11-03 17:37:12 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-03 17:42:38 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:48:19 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6beed581f1e7936cee213ad551116228f7f91c86
Cr-Commit-Position: refs/heads/master@{#429636}

Powered by Google App Engine
This is Rietveld 408576698