Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issue 2470363004: EME: Fix promise_test() to actually return a promise. (Closed)

Created:
4 years, 1 month ago by jrummell
Modified:
4 years, 1 month ago
Reviewers:
xhwang, ddorwin
CC:
chromium-reviews, blink-reviews, feature-media-reviews_chromium.org, Srirama, mlamouri+watch-blink_chromium.org, eric.carlson_apple.com
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

EME: Fix promise_test() to actually return a promise. Latest testharness.js checks that promise_test() actually returns something, so add missing return to the test. BUG=662172 TEST=updated test still passes Committed: https://crrev.com/239d2c25b718e99695655af2c39577dd86d605c6 Cr-Commit-Position: refs/heads/master@{#430029}

Patch Set 1 #

Patch Set 2 : remove expected.txt file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-unique-origin.html View 2 chunks +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-unique-origin-expected.txt View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
jrummell
Trivial fix, same as what was done for the W3C EME tests to use the ...
4 years, 1 month ago (2016-11-04 01:09:17 UTC) #2
xhwang
lgtm
4 years, 1 month ago (2016-11-04 02:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470363004/1
4 years, 1 month ago (2016-11-04 16:57:36 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/325832)
4 years, 1 month ago (2016-11-04 18:02:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470363004/20001
4 years, 1 month ago (2016-11-04 20:42:23 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 22:08:37 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 22:10:33 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/239d2c25b718e99695655af2c39577dd86d605c6
Cr-Commit-Position: refs/heads/master@{#430029}

Powered by Google App Engine
This is Rietveld 408576698