Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2615)

Unified Diff: ash/common/wm/overview/window_selector.cc

Issue 2470343003: Use mirror layer for minimized windows in overview mode (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/common/wm/overview/window_selector.cc
diff --git a/ash/common/wm/overview/window_selector.cc b/ash/common/wm/overview/window_selector.cc
index 49a56dbaf642564cd06b9d4f19397ac2daa5c440..a898f83be197262479b8d85b50bb242ae5237f69 100644
--- a/ash/common/wm/overview/window_selector.cc
+++ b/ash/common/wm/overview/window_selector.cc
@@ -97,7 +97,7 @@ struct WindowSelectorItemTargetComparator {
: target(target_window) {}
bool operator()(WindowSelectorItem* window) const {
- return window->GetWindow() == target;
+ return window->Contains(target);
}
const WmWindow* target;
@@ -567,10 +567,8 @@ void WindowSelector::OnWindowActivated(WmWindow* gained_active,
auto iter = std::find_if(windows.begin(), windows.end(),
WindowSelectorItemTargetComparator(gained_active));
- if (iter != windows.end()) {
- (*iter)->ShowWindowOnExit();
- } else if (showing_text_filter_ &&
- lost_active == GetTextFilterWidgetWindow()) {
+ if (iter == windows.end() && showing_text_filter_ &&
+ lost_active == GetTextFilterWidgetWindow()) {
return;
}

Powered by Google App Engine
This is Rietveld 408576698