Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Issue 2470343002: Fix iOS code signing issue (Closed)

Created:
4 years, 1 month ago by kthelgason_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix iOS code signing issue Fix a bug where code signing on iOS would fail if the iPhone developer identity is not the first item in the output of `security find-identity` BUG=chromium:661944 Committed: https://crrev.com/784ae901cc0ee477e57f50d25f801f1ab17882f1 Cr-Commit-Position: refs/heads/master@{#429561}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/ios/find_signing_identity.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kthelgason_chromium
please take a look
4 years, 1 month ago (2016-11-03 11:19:50 UTC) #2
kjellander_chromium
lgtm
4 years, 1 month ago (2016-11-03 12:44:33 UTC) #3
sdefresne
lgtm
4 years, 1 month ago (2016-11-03 13:27:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470343002/1
4 years, 1 month ago (2016-11-03 13:31:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 13:40:16 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 13:42:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/784ae901cc0ee477e57f50d25f801f1ab17882f1
Cr-Commit-Position: refs/heads/master@{#429561}

Powered by Google App Engine
This is Rietveld 408576698