Replace for each loop

net/log/net_log_util.cc

Index: net/log/net_log_util.cc
diff --git a/net/log/net_log_util.cc b/net/log/net_log_util.cc
index da724e9f0bbb41693e0494b2110c1a8f2347728b..eb92424a7badc244e5040c80e9eb87d7c440e7e4 100644
--- a/net/log/net_log_util.cc
+++ b/net/log/net_log_util.cc
@@ -158,8 +158,9 @@ std::unique_ptr<base::DictionaryValue> GetNetConstants() {
   {
     std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-    for (size_t i = 0; i < arraysize(kCertStatusFlags); i++)
-      dict->SetInteger(kCertStatusFlags[i].name, kCertStatusFlags[i].constant);
+    for (StringToConstant flag : kCertStatusFlags) {

[eroman, 2016/11/03 14:39:43]

Please use:
   for (const auto& flag : kCertStatusFlags) {

(Avoids unnecessary copies).

+      dict->SetInteger(flag.name, flag.constant);
+    }
 
     constants_dict->Set("certStatusFlag", std::move(dict));
   }
@@ -169,8 +170,9 @@ std::unique_ptr<base::DictionaryValue> GetNetConstants() {
   {
     std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-    for (size_t i = 0; i < arraysize(kLoadFlags); i++)
-      dict->SetInteger(kLoadFlags[i].name, kLoadFlags[i].constant);
+    for (StringToConstant flag : kLoadFlags) {
+      dict->SetInteger(flag.name, flag.constant);
+    }
 
     constants_dict->Set("loadFlag", std::move(dict));
   }
@@ -180,8 +182,9 @@ std::unique_ptr<base::DictionaryValue> GetNetConstants() {
   {
     std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-    for (size_t i = 0; i < arraysize(kLoadStateTable); i++)
-      dict->SetInteger(kLoadStateTable[i].name, kLoadStateTable[i].constant);
+    for (StringToConstant flag : kLoadStateTable) {
+      dict->SetInteger(flag.name, flag.constant);
+    }
 
     constants_dict->Set("loadState", std::move(dict));
   }
@@ -200,8 +203,9 @@ std::unique_ptr<base::DictionaryValue> GetNetConstants() {
   {
     std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-    for (size_t i = 0; i < arraysize(kNetErrors); i++)
-      dict->SetInteger(ErrorToShortString(kNetErrors[i]), kNetErrors[i]);
+    for (short error : kNetErrors) {

[eroman, 2016/11/03 14:39:43]

(Side-note: kNetErrors should probably be defined as an Error instead of short.
Not sure if this was done intentionally to save space...)

+      dict->SetInteger(ErrorToShortString(error), error);
+    }
 
     constants_dict->Set("netError", std::move(dict));
   }
@@ -240,8 +244,9 @@ std::unique_ptr<base::DictionaryValue> GetNetConstants() {
   {
     std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue());
 
-    for (size_t i = 0; i < arraysize(kSdchProblems); i++)
-      dict->SetInteger(kSdchProblems[i].name, kSdchProblems[i].constant);
+    for (StringToConstant problem : kSdchProblems) {
+      dict->SetInteger(problem.name, problem.constant);
+    }
 
     constants_dict->Set("sdchProblemCode", std::move(dict));
   }