Replace for each loop

Replace for each loop

BUG=655950
Committed: https://crrev.com/6dea603ddfb631a7645e7ca95ea47e5a1291db29
Cr-Commit-Position: refs/heads/master@{#429627}

[Yoonjae, 2016-11-03 07:25:19]

yoonjae.cho92@gmail.com changed reviewers:
+ rsleevi@chromium.org

[Yoonjae, 2016-11-03 07:25:19]

@rsleevi
PTAL.

[eroman, 2016-11-03 14:39:42]

eroman@chromium.org changed reviewers:
+ eroman@chromium.org

[eroman, 2016-11-03 14:39:43]

https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc
File net/log/net_log_util.cc (right):

https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc#new...
net/log/net_log_util.cc:161: for (StringToConstant flag : kCertStatusFlags) {
Please use:
   for (const auto& flag : kCertStatusFlags) {

(Avoids unnecessary copies).

https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc#new...
net/log/net_log_util.cc:206: for (short error : kNetErrors) {
(Side-note: kNetErrors should probably be defined as an Error instead of short.
Not sure if this was done intentionally to save space...)

[Yoonjae, 2016-11-03 15:01:54]

On 2016/11/03 14:39:43, eroman wrote:
> https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc
> File net/log/net_log_util.cc (right):
> 
>
https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc#new...
> net/log/net_log_util.cc:161: for (StringToConstant flag : kCertStatusFlags) {
> Please use:
>    for (const auto& flag : kCertStatusFlags) {
> 
> (Avoids unnecessary copies).
> 
>
https://codereview.chromium.org/2470273003/diff/1/net/log/net_log_util.cc#new...
> net/log/net_log_util.cc:206: for (short error : kNetErrors) {
> (Side-note: kNetErrors should probably be defined as an Error instead of
short.
> Not sure if this was done intentionally to save space...)

@eroman
Done. PTAL.

[eroman, 2016-11-03 16:07:08]

lgtm

[Yoonjae, 2016-11-03 16:07:44]

The CQ bit was checked by yoonjae.cho92@gmail.com

[commit-bot: I haz the power, 2016-11-03 16:08:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 17:23:19]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-03 17:48:03]

Description was changed from

==========
Replace for each loop

BUG=655950
==========

to

==========
Replace for each loop

BUG=655950

Committed: https://crrev.com/6dea603ddfb631a7645e7ca95ea47e5a1291db29
Cr-Commit-Position: refs/heads/master@{#429627}
==========

[commit-bot: I haz the power, 2016-11-03 17:48:04]

Patchset 3 (id:??) landed as
https://crrev.com/6dea603ddfb631a7645e7ca95ea47e5a1291db29
Cr-Commit-Position: refs/heads/master@{#429627}