Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 2470273002: [Devtools] Fixed new timeline simplified bars popover hover (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Fixed new timeline simplified bars popover hover This patch fixes the new timeline canvas experiment to have a popover for simplified bars. R=dgozman BUG=653738 Committed: https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67 Cr-Commit-Position: refs/heads/master@{#429822}

Patch Set 1 #

Total comments: 4

Patch Set 2 : changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -18 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 3 chunks +35 lines, -18 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
allada
PTL
4 years, 1 month ago (2016-11-03 00:58:56 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode27 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:27: this._borderOffset = .5; I'm not sure what the ...
4 years, 1 month ago (2016-11-03 21:52:43 UTC) #6
allada
done https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode27 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:27: this._borderOffset = .5; On 2016/11/03 21:52:43, dgozman wrote: ...
4 years, 1 month ago (2016-11-03 22:31:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470273002/20001
4 years, 1 month ago (2016-11-03 22:33:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/330632)
4 years, 1 month ago (2016-11-04 00:31:11 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470273002/20001
4 years, 1 month ago (2016-11-04 00:35:18 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/325285)
4 years, 1 month ago (2016-11-04 03:41:24 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470273002/20001
4 years, 1 month ago (2016-11-04 04:24:33 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 07:17:23 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 07:20:07 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67
Cr-Commit-Position: refs/heads/master@{#429822}

Powered by Google App Engine
This is Rietveld 408576698