|
|
Chromium Code Reviews|
Created:
4 years, 1 month ago by allada Modified:
4 years, 1 month ago Reviewers:
dgozman CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Fixed new timeline simplified bars popover hover
This patch fixes the new timeline canvas experiment to have a popover
for simplified bars.
R=dgozman
BUG=653738
Committed: https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67
Cr-Commit-Position: refs/heads/master@{#429822}
Patch Set 1 #
Total comments: 4
Patch Set 2 : changes #Messages
Total messages: 21 (11 generated)
PTL
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
lgtm https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:27: this._borderOffset = .5; I'm not sure what the styleguide says, but I prefer 0.5 :-) https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:417: const borderWidth = 1; Should this be 2 * this._borderOffset?
done https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:27: this._borderOffset = .5; On 2016/11/03 21:52:43, dgozman wrote: > I'm not sure what the styleguide says, but I prefer 0.5 :-) Done. https://codereview.chromium.org/2470273002/diff/1/third_party/WebKit/Source/d... third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:417: const borderWidth = 1; On 2016/11/03 21:52:43, dgozman wrote: > Should this be 2 * this._borderOffset? Done.
The CQ bit was checked by allada@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2470273002/#ps20001 (title: "changes")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed new timeline simplified bars popover hover This patch fixes the new timeline canvas experiment to have a popover for simplified bars. R=dgozman BUG=653738 ========== to ========== [Devtools] Fixed new timeline simplified bars popover hover This patch fixes the new timeline canvas experiment to have a popover for simplified bars. R=dgozman BUG=653738 Committed: https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67 Cr-Commit-Position: refs/heads/master@{#429822} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f85750693cce8a4320b18552bdb51c0bcae90a67 Cr-Commit-Position: refs/heads/master@{#429822} |
