third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp - Issue 2470233009: WTF/std normalization: replace WTF::Vector::first() with ::front()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp

Issue 2470233009: WTF/std normalization: replace WTF::Vector::first() with ::front() (Closed)

Patch Set: rebase Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageDecoder.cpp ('k') | third_party/WebKit/Source/web/SuspendableScriptExecutor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp

index 10ccb5d41d21128766e0e79a222a79d358d1ad17..4ccfae20bdbce4fd1bd55b3fc3da53d62b309af5 100644

--- a/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.cpp

@@ -281,7 +281,7 @@ bool ICOImageDecoder::processDirectoryEntries() {

std::sort(m_dirEntries.begin(), m_dirEntries.end(), compareEntries);

// The image size is the size of the largest entry.

- const IconDirectoryEntry& dirEntry = m_dirEntries.first();

+ const IconDirectoryEntry& dirEntry = m_dirEntries.front();

// Technically, this next call shouldn't be able to fail, since the width

// and height here are each <= 256, and |m_frameSize| is empty.

return setSize(dirEntry.m_size.width(), dirEntry.m_size.height());