[MediaNotification] Listen to previous/next track from Android MediaSession

[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563
Committed: https://crrev.com/2ad79b35d6c1a054c1f38681deff659cd2f3b00d
Cr-Commit-Position: refs/heads/master@{#429921}

[Zhiqiang Zhang (Slow), 2016-11-04 16:01:28]

Description was changed from

==========
[MediaNotification] Listen to previous/next track from the OS

BUG=656563
==========

to

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

BUG=656563
==========

[Zhiqiang Zhang (Slow), 2016-11-04 16:03:34]

Description was changed from

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

BUG=656563
==========

to

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563
==========

[Zhiqiang Zhang (Slow), 2016-11-04 16:03:44]

zqzhang@chromium.org changed reviewers:
+ avayvod@chromium.org

[whywhat, 2016-11-04 16:22:45]

lgtm

Are you going to implement the default behavior for these actions (in Blink I
assume)? IIRC, Safari does seek to 0 for prev track and seek to duration for the
next track. Both sound reasonable to me (seeking to 0 is what most apps do on
the first prev track anyway and seeking to duration will probably make the site
switch to the next track automatically).

[Zhiqiang Zhang (Slow), 2016-11-04 16:32:25]

On 2016/11/04 16:22:45, whywhat wrote:
> lgtm
> 
> Are you going to implement the default behavior for these actions (in Blink I
> assume)? IIRC, Safari does seek to 0 for prev track and seek to duration for
the
> next track. Both sound reasonable to me (seeking to 0 is what most apps do on
> the first prev track anyway and seeking to duration will probably make the
site
> switch to the next track automatically).

Hmm, probably. Actually IMHO websites might hate the default behaviors since it
a bit hackish,
and different browsers may have different implementation (unless we write it in
the spec).
Handling these events by the website themselves should be much easier than
guessing what the browser will do for them by default.

[Zhiqiang Zhang (Slow), 2016-11-04 16:32:30]

The CQ bit was checked by zqzhang@chromium.org

[commit-bot: I haz the power, 2016-11-04 16:32:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[whywhat, 2016-11-04 16:37:21]

On 2016/11/04 at 16:32:25, zqzhang wrote:
> On 2016/11/04 16:22:45, whywhat wrote:
> > lgtm
> > 
> > Are you going to implement the default behavior for these actions (in Blink
I
> > assume)? IIRC, Safari does seek to 0 for prev track and seek to duration for
the
> > next track. Both sound reasonable to me (seeking to 0 is what most apps do
on
> > the first prev track anyway and seeking to duration will probably make the
site
> > switch to the next track automatically).
> 
> Hmm, probably. Actually IMHO websites might hate the default behaviors since
it a bit hackish,
> and different browsers may have different implementation (unless we write it
in the spec).
> Handling these events by the website themselves should be much easier than
guessing what the browser will do for them by default.

It might be okay to spec it (or have a note that this is likely), esp. if we
have other vendors agreement.
This is not for the websites using the API but for the websites not using it
that could just work.
That would solve the problem of having only play/pause button in the
notification too.

[commit-bot: I haz the power, 2016-11-04 17:04:08]

Description was changed from

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563
==========

to

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563
==========

[commit-bot: I haz the power, 2016-11-04 17:04:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-04 17:16:11]

Description was changed from

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563
==========

to

==========
[MediaNotification] Listen to previous/next track from Android MediaSession

This CL makes media notification respond to previous/next track
controls from Android MediaSession in addition to the
notification buttons.

BUG=656563

Committed: https://crrev.com/2ad79b35d6c1a054c1f38681deff659cd2f3b00d
Cr-Commit-Position: refs/heads/master@{#429921}
==========

[commit-bot: I haz the power, 2016-11-04 17:16:12]

Patchset 1 (id:??) landed as
https://crrev.com/2ad79b35d6c1a054c1f38681deff659cd2f3b00d
Cr-Commit-Position: refs/heads/master@{#429921}