Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2470233006: Add chrome://signin-internals to chrome://chrome-urls on iOS (Closed)

Created:
4 years, 1 month ago by bzanotti
Modified:
4 years, 1 month ago
Reviewers:
sdefresne
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chrome://signin-internals to chrome://chrome-urls on iOS BUG=648241 Committed: https://crrev.com/a3daa089fcb74b4f03c89c7a56676e07315ffb36 Cr-Commit-Position: refs/heads/master@{#429845}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M ios/chrome/browser/chrome_url_constants.cc View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bzanotti
Please take a look.
4 years, 1 month ago (2016-11-04 09:45:56 UTC) #2
sdefresne
lgtm
4 years, 1 month ago (2016-11-04 10:07:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470233006/1
4 years, 1 month ago (2016-11-04 10:12:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 10:22:04 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 10:24:13 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3daa089fcb74b4f03c89c7a56676e07315ffb36
Cr-Commit-Position: refs/heads/master@{#429845}

Powered by Google App Engine
This is Rietveld 408576698