Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2470233003: headless: Librarify Headless Shell (Closed)

Created:
4 years, 1 month ago by Sami
Modified:
4 years, 1 month ago
Reviewers:
Eric Seckler
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Librarify Headless Shell Turn the Headless Shell application into a library so it can be embedded by other targets (e.g., Chrome). This moves the shell into headless namespace and adds exports new function for the main shell entrypoint, which is intented to be called from main() when the Headless Shell should be started. BUG=612904 Committed: https://crrev.com/a270240bc1d0d59ad000acb65b83639e466c12c3 Cr-Commit-Position: refs/heads/master@{#429572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -47 lines) Patch
M headless/BUILD.gn View 1 chunk +12 lines, -1 line 0 comments Download
M headless/app/headless_shell.cc View 13 chunks +37 lines, -43 lines 0 comments Download
A + headless/app/headless_shell_main.cc View 1 chunk +3 lines, -3 lines 0 comments Download
A headless/public/headless_shell.h View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sami
4 years, 1 month ago (2016-11-03 12:41:50 UTC) #4
Eric Seckler
lgtm
4 years, 1 month ago (2016-11-03 12:54:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470233003/1
4 years, 1 month ago (2016-11-03 13:22:33 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 14:13:56 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 14:15:58 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a270240bc1d0d59ad000acb65b83639e466c12c3
Cr-Commit-Position: refs/heads/master@{#429572}

Powered by Google App Engine
This is Rietveld 408576698