Source/core/page/EventHandler.cpp - Issue 247023002: Correcting menu button event trigger location

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/EventHandler.cpp

Issue 247023002: Correcting menu button event trigger location (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Added layout test (only for Linux and Windows) Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/EventHandler.cpp

diff --git a/Source/core/page/EventHandler.cpp b/Source/core/page/EventHandler.cpp

index 8d33eba40c5b70d75204e2d4f385d2877b167ecb..231d0b33fa750b34c39224ce390efe4c9679d766 100644

--- a/Source/core/page/EventHandler.cpp

+++ b/Source/core/page/EventHandler.cpp

@@ -2711,11 +2711,8 @@ bool EventHandler::sendContextMenuEventForKey()

int y = firstRect.maxY() ? firstRect.maxY() - 1 : 0;

location = IntPoint(x, y);

} else if (focusedElement) {

- RenderBoxModelObject* box = focusedElement->renderBoxModelObject();

- if (!box)

- return false;

- IntRect clippedRect = box->pixelSnappedAbsoluteClippedOverflowRect();

- location = IntPoint(clippedRect.x(), clippedRect.maxY() - 1);

+ IntRect clippedRect = focusedElement->boundsInRootViewSpace();

+ location = IntPoint(clippedRect.center());

} else {

location = IntPoint(

rightAligned ? view->contentsWidth() - kContextMenuMargin : kContextMenuMargin,