Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 2470223002: Add a missing file in cc/BUILD.gn (Closed)

Created:
4 years, 1 month ago by wychen
Modified:
4 years, 1 month ago
CC:
cc-bugs_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a missing file in cc/BUILD.gn BUG=661774 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Committed: https://crrev.com/800b09977f716af90ab96ba5c56e205c8a9c14a2 Cr-Commit-Position: refs/heads/master@{#429540}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M cc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
wychen
PTAL
4 years, 1 month ago (2016-11-02 21:31:36 UTC) #3
aelias_OOO_until_Jul13
lgtm
4 years, 1 month ago (2016-11-03 01:06:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470223002/1
4 years, 1 month ago (2016-11-03 03:23:57 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/310021)
4 years, 1 month ago (2016-11-03 05:05:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470223002/1
4 years, 1 month ago (2016-11-03 05:14:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years, 1 month ago (2016-11-03 05:24:27 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470223002/1
4 years, 1 month ago (2016-11-03 06:34:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-03 09:00:45 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 09:03:14 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/800b09977f716af90ab96ba5c56e205c8a9c14a2
Cr-Commit-Position: refs/heads/master@{#429540}

Powered by Google App Engine
This is Rietveld 408576698