Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Issue 24702003: [webcrypto] Remove the mock implementation of WebCrypto. (Closed)

Created:
7 years, 2 months ago by eroman
Modified:
7 years, 2 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org, Bryan Eyler, Ryan Sleevi
Visibility:
Public.

Description

[webcrypto] Remove the mock implementation of WebCrypto. Instead let the layout tests run with WebCryptoImpl. R=jamesr@chromium.org, jochen@chromium.org TBR=joi BUG=245025 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225665

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add ContentRendererClient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M content/public/renderer/content_renderer_client.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/renderer/content_renderer_client.cc View 1 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/shell/renderer/shell_content_renderer_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/shell/renderer/shell_content_renderer_client.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
eroman
This is a dependency for https://codereview.chromium.org/24467004/. My plan is to (1) disable the crypto layout ...
7 years, 2 months ago (2013-09-26 00:59:57 UTC) #1
jamesr
lgtm, although i have no content/shell powers. adding jochen for that
7 years, 2 months ago (2013-09-26 01:01:12 UTC) #2
jochen (gone - plz use gerrit)
lgtm for content/shell https://codereview.chromium.org/24702003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (left): https://codereview.chromium.org/24702003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#oldcode1044 content/renderer/renderer_webkitplatformsupport_impl.cc:1044: GetContentClient()->renderer()->OverrideWebCrypto(); can you rip out the ...
7 years, 2 months ago (2013-09-26 20:19:37 UTC) #3
eroman
https://codereview.chromium.org/24702003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc File content/renderer/renderer_webkitplatformsupport_impl.cc (left): https://codereview.chromium.org/24702003/diff/1/content/renderer/renderer_webkitplatformsupport_impl.cc#oldcode1044 content/renderer/renderer_webkitplatformsupport_impl.cc:1044: GetContentClient()->renderer()->OverrideWebCrypto(); On 2013/09/26 20:19:37, jochen wrote: > can you ...
7 years, 2 months ago (2013-09-26 20:54:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24702003/6001
7 years, 2 months ago (2013-09-27 00:30:57 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=27704
7 years, 2 months ago (2013-09-27 01:20:14 UTC) #6
eroman
+joi for approval of content/public/renderer/* (I will likely submit this TBR since it is removing ...
7 years, 2 months ago (2013-09-27 01:30:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24702003/6001
7 years, 2 months ago (2013-09-27 01:36:25 UTC) #8
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=82071
7 years, 2 months ago (2013-09-27 03:48:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/24702003/6001
7 years, 2 months ago (2013-09-27 04:09:10 UTC) #10
eroman
Committed patchset #2 manually as r225665 (presubmit successful).
7 years, 2 months ago (2013-09-27 05:16:08 UTC) #11
Jói
7 years, 2 months ago (2013-09-27 10:49:14 UTC) #12
Message was sent while issue was closed.
//content/public LGTM.

Powered by Google App Engine
This is Rietveld 408576698