extensions/common/api/_api_features.json - Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/common/api/_api_features.json

Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate (Closed)

Patch Set: networkConfig -> networking.onc Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_permission_message_rules.cc ('k') | extensions/common/api/_behavior_features.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/common/api/_api_features.json

diff --git a/extensions/common/api/_api_features.json b/extensions/common/api/_api_features.json

index 5380a15a5e340fb2e79b95d93053db5e51838c87..5679bab1d6c214da7a2f6eaca158ca660aca1a9e 100644

--- a/extensions/common/api/_api_features.json

+++ b/extensions/common/api/_api_features.json

@@ -300,9 +300,30 @@

"dependencies": ["permission:networking.config"],

"contexts": ["blessed_extension"]

+ "networking.onc": [{

+ "dependencies": ["permission:networking.onc"],

+ "contexts": ["blessed_extension"],

+ "source": "networkingPrivate"

+ }, {

+ "channel": "stable",

Devlin 2016/12/09 18:23:20 Do we need this? It seems like for webui we shoul

tbarzic 2016/12/09 18:51:32 Sure, I can add this when we switch web UI to netw

+ "contexts": ["webui"],

+ "matches": [

+ "chrome://md-settings/*",

+ "chrome://network/*",

+ "chrome://oobe/*",

+ "chrome://settings/*",

+ "chrome://settings-frame/*"

+ ]

+ }],

"networkingPrivate": [{

"dependencies": ["permission:networkingPrivate"],

- "contexts": ["blessed_extension"]

+ "contexts": ["blessed_extension"],

+ // TODO(tbarzic): networkingPrivate is being renamed to networking.onc.

+ // The goal is to eventually remove networkingPrivate API in favour of

+ // networking.onc, but until current usages are migrated to the new

+ // name, use API aliasing to expose the API under both names.

+ // (http://crbug.com/672186).

+ "alias": "networking.onc"

}, {

"channel": "stable",

"contexts": ["webui"],