extensions/common/features/behavior_feature.h - Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/common/features/behavior_feature.h

Issue 2470193002: Introduce networking.onc as an alias for networkingPrivate (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/common/api/_permission_features.json ('K') | « extensions/common/extension_api.cc ('k') | extensions/common/features/behavior_feature.cc » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_	5 #ifndef EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_

6 #define EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_	6 #define EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_

7	7

8 namespace extensions {	8 namespace extensions {

9	9

10 // Contains constants corresponding to keys in _behavior_features.json.	10 // Contains constants corresponding to keys in _behavior_features.json.

11 // One day we might want to auto generate these.	11 // One day we might want to auto generate these.

12 namespace behavior_feature {	12 namespace behavior_feature {

13	13

14 extern const char kWhitelistedForIncognito[];	14 extern const char kWhitelistedForIncognito[];

15 extern const char kDoNotSync[];	15 extern const char kDoNotSync[];

16 extern const char kZoomWithoutBubble[];	16 extern const char kZoomWithoutBubble[];

17 extern const char kAllowUsbDevicesPermissionInterfaceClass[];	17 extern const char kAllowUsbDevicesPermissionInterfaceClass[];

18 extern const char kSigninScreen[];	18 extern const char kSigninScreen[];

	19 extern const char kWhitelistedForNetworkApi[];
	stevenjb 2016/12/07 21:35:31 Here too. Because we (unfortunately) also have a " Here too. Because we (unfortunately) also have a "networking.config" API, I think we should be explicit and use "NetworkConfigApi", with a comment somewhere (maybe in the .json file?) that we are currently aliasing networkConfig -> networkingPrivate, but eventually plan to migrate everything to networkConfig and deprecate networkingPrivate. tbarzic 2016/12/07 22:32:53 Done. Show quoted text On 2016/12/07 21:35:31, stevenjb wrote: > Here too. Because we (unfortunately) also have a "networking.config" API, I > think we should be explicit and use "NetworkConfigApi", with a comment somewhere > (maybe in the .json file?) that we are currently aliasing networkConfig -> > networkingPrivate, but eventually plan to migrate everything to networkConfig > and deprecate networkingPrivate. Done.
19	20

20 } // namespace behavior_feature	21 } // namespace behavior_feature

21	22

22 } // namespace extensions	23 } // namespace extensions

23	24

24 #endif // EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_	25 #endif // EXTENSIONS_COMMON_FEATURES_BEHAVIOR_FEATURE_H_

OLD	NEW