Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2470183002: Fix vcall on nullptr in ~Performance. (Closed)

Created:
4 years, 1 month ago by krasin1
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix vcall on nullptr in ~Performance. This is a follow up to https://codereview.chromium.org/2449673002/ BUG=607996 Committed: https://crrev.com/ebf0e626c43b986e5dfed5e961575bf31760a11c Cr-Commit-Position: refs/heads/master@{#429409}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M third_party/WebKit/Source/core/timing/Performance.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
krasin1
4 years, 1 month ago (2016-11-02 20:14:59 UTC) #3
panickercorp
lgtm
4 years, 1 month ago (2016-11-02 20:27:01 UTC) #6
krasin1
On 2016/11/02 20:27:01, panicker wrote: > lgtm Thank you! I guess, I also need an ...
4 years, 1 month ago (2016-11-02 20:30:48 UTC) #7
dgozman
lgtm
4 years, 1 month ago (2016-11-02 20:50:58 UTC) #8
krasin1
On 2016/11/02 20:50:58, dgozman wrote: > lgtm Thank you, Dmitry!
4 years, 1 month ago (2016-11-02 20:51:43 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470183002/1
4 years, 1 month ago (2016-11-02 20:52:04 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-02 21:45:24 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 21:47:24 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ebf0e626c43b986e5dfed5e961575bf31760a11c
Cr-Commit-Position: refs/heads/master@{#429409}

Powered by Google App Engine
This is Rietveld 408576698