Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 2470173003: Cherry-pick r237153: [Mips] Return false for isFPCloseToIncomingSP() (Closed)

Created:
4 years, 1 month ago by petarj
Modified:
4 years, 1 month ago
Reviewers:
Mark Seaborn
CC:
native-client-reviews_googlegroups.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cherry-pick r237153: [Mips] Return false for isFPCloseToIncomingSP() On Mips, frame pointer points to the same side of the frame as the stack pointer. This function is used to decide where to put register scavenging spill slot. So far, it was put on the wrong side of the frame, and thus it was too far away from $fp when frame was larger than 2^15 bytes. Patch by Vladimir Radosavljevic. http://reviews.llvm.org/D8895 BUG= pnacl-llc aborts on run_vector_extension_test for MIPS R=mseaborn@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/1d79adfbc0115376d75323642038e5193f94b6af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -0 lines) Patch
M lib/Target/Mips/MipsFrameLowering.h View 1 chunk +2 lines, -0 lines 0 comments Download
A test/CodeGen/Mips/emergency-spill-slot-near-fp.ll View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
petarj
PTAL.
4 years, 1 month ago (2016-11-03 18:23:13 UTC) #3
Mark Seaborn
LGTM
4 years, 1 month ago (2016-11-03 19:05:23 UTC) #4
petarj
4 years, 1 month ago (2016-11-03 20:22:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1d79adfbc0115376d75323642038e5193f94b6af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698