Revert of [Sync] Adds a new switch for enabling the new local server backend.

Revert of [Sync] Adds a new switch for enabling the new local server backend. (patchset #6 id:100001 of https://codereview.chromium.org/2442453002/ )

Reason for revert:
Speculative revert to fix "sizes" on "Linux x64" bot.

Failed build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27974

Error message:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7, better lower

Most likely due to using:

    const base::FilePath::StringType kLoopbackServerBackendFilename

instead of

    static const base::FilePath::CharType kLoopbackServerBackendFilename[]

as on line 153 in profile_sync_service.cc.

Original issue's description:
> Adds a new switch for enabling the new local server backend.
>
> Actually two flags which play in tandem:
>
> --enable-local-sync-backend and --local-sync-backend-dir
>
> The second is respected only if the first one is specified.
> Eventually those will be controlled by policy but the flags will allow
> easier testing and potentially unlock the feature for advanced users.
>
> For now sign-in is needed to kick the sync logic on but the data
> is only stored locally when this flag is specified.
>
> BUG=651411
> TEST=unit_tests/manual.
>
> Committed: https://crrev.com/d69772aa33ea1ad4e53b5236bb66fc92c1e7cc0a
> Cr-Commit-Position: refs/heads/master@{#429280}

TBR=pavely@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651411
Committed: https://crrev.com/78dd9909be3e5dc00573387ba54e79010624d198
Cr-Commit-Position: refs/heads/master@{#429284}

[please use gerrit instead, 2016-11-02 15:45:01]

The CQ bit was checked by rouslan@chromium.org

[please use gerrit instead, 2016-11-02 15:45:01]

Created Revert of [Sync] Adds a new switch for enabling the new local server
backend.

[commit-bot: I haz the power, 2016-11-02 15:45:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 15:46:35]

Description was changed from

==========
Revert of [Sync] Adds a new switch for enabling the new local server backend.
(patchset #6 id:100001 of https://codereview.chromium.org/2442453002/ )

Reason for revert:
Speculative revert to fix "sizes" on "Linux x64" bot.

Failed build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27974

Error message:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Most likely due to using:

    const base::FilePath::StringType kLoopbackServerBackendFilename

instead of

    static const base::FilePath::CharType kLoopbackServerBackendFilename[]

as on line 153 in profile_sync_service.cc.

Original issue's description:
> Adds a new switch for enabling the new local server backend.
> 
> Actually two flags which play in tandem:
> 
> --enable-local-sync-backend and --local-sync-backend-dir
> 
> The second is respected only if the first one is specified.
> Eventually those will be controlled by policy but the flags will allow
> easier testing and potentially unlock the feature for advanced users.
> 
> For now sign-in is needed to kick the sync logic on but the data
> is only stored locally when this flag is specified.
> 
> BUG=651411
> TEST=unit_tests/manual.
> 
> Committed: https://crrev.com/d69772aa33ea1ad4e53b5236bb66fc92c1e7cc0a
> Cr-Commit-Position: refs/heads/master@{#429280}

TBR=pavely@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651411
==========

to

==========
Revert of [Sync] Adds a new switch for enabling the new local server backend.
(patchset #6 id:100001 of https://codereview.chromium.org/2442453002/ )

Reason for revert:
Speculative revert to fix "sizes" on "Linux x64" bot.

Failed build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27974

Error message:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Most likely due to using:

    const base::FilePath::StringType kLoopbackServerBackendFilename

instead of

    static const base::FilePath::CharType kLoopbackServerBackendFilename[]

as on line 153 in profile_sync_service.cc.

Original issue's description:
> Adds a new switch for enabling the new local server backend.
> 
> Actually two flags which play in tandem:
> 
> --enable-local-sync-backend and --local-sync-backend-dir
> 
> The second is respected only if the first one is specified.
> Eventually those will be controlled by policy but the flags will allow
> easier testing and potentially unlock the feature for advanced users.
> 
> For now sign-in is needed to kick the sync logic on but the data
> is only stored locally when this flag is specified.
> 
> BUG=651411
> TEST=unit_tests/manual.
> 
> Committed: https://crrev.com/d69772aa33ea1ad4e53b5236bb66fc92c1e7cc0a
> Cr-Commit-Position: refs/heads/master@{#429280}

TBR=pavely@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651411
==========

[commit-bot: I haz the power, 2016-11-02 15:46:36]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-02 15:50:33]

Description was changed from

==========
Revert of [Sync] Adds a new switch for enabling the new local server backend.
(patchset #6 id:100001 of https://codereview.chromium.org/2442453002/ )

Reason for revert:
Speculative revert to fix "sizes" on "Linux x64" bot.

Failed build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27974

Error message:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Most likely due to using:

    const base::FilePath::StringType kLoopbackServerBackendFilename

instead of

    static const base::FilePath::CharType kLoopbackServerBackendFilename[]

as on line 153 in profile_sync_service.cc.

Original issue's description:
> Adds a new switch for enabling the new local server backend.
> 
> Actually two flags which play in tandem:
> 
> --enable-local-sync-backend and --local-sync-backend-dir
> 
> The second is respected only if the first one is specified.
> Eventually those will be controlled by policy but the flags will allow
> easier testing and potentially unlock the feature for advanced users.
> 
> For now sign-in is needed to kick the sync logic on but the data
> is only stored locally when this flag is specified.
> 
> BUG=651411
> TEST=unit_tests/manual.
> 
> Committed: https://crrev.com/d69772aa33ea1ad4e53b5236bb66fc92c1e7cc0a
> Cr-Commit-Position: refs/heads/master@{#429280}

TBR=pavely@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651411
==========

to

==========
Revert of [Sync] Adds a new switch for enabling the new local server backend.
(patchset #6 id:100001 of https://codereview.chromium.org/2442453002/ )

Reason for revert:
Speculative revert to fix "sizes" on "Linux x64" bot.

Failed build:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27974

Error message:
FAILED linux-release-64/sizes/chrome-si/initializers: actual 8, expected 7,
better lower

Most likely due to using:

    const base::FilePath::StringType kLoopbackServerBackendFilename

instead of

    static const base::FilePath::CharType kLoopbackServerBackendFilename[]

as on line 153 in profile_sync_service.cc.

Original issue's description:
> Adds a new switch for enabling the new local server backend.
>
> Actually two flags which play in tandem:
>
> --enable-local-sync-backend and --local-sync-backend-dir
>
> The second is respected only if the first one is specified.
> Eventually those will be controlled by policy but the flags will allow
> easier testing and potentially unlock the feature for advanced users.
>
> For now sign-in is needed to kick the sync logic on but the data
> is only stored locally when this flag is specified.
>
> BUG=651411
> TEST=unit_tests/manual.
>
> Committed: https://crrev.com/d69772aa33ea1ad4e53b5236bb66fc92c1e7cc0a
> Cr-Commit-Position: refs/heads/master@{#429280}

TBR=pavely@chromium.org,pastarmovj@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=651411

Committed: https://crrev.com/78dd9909be3e5dc00573387ba54e79010624d198
Cr-Commit-Position: refs/heads/master@{#429284}
==========

[commit-bot: I haz the power, 2016-11-02 15:50:34]

Patchset 1 (id:??) landed as
https://crrev.com/78dd9909be3e5dc00573387ba54e79010624d198
Cr-Commit-Position: refs/heads/master@{#429284}

[please use gerrit instead, 2016-11-02 16:32:28]

The build with the revert is passing again:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27976

This patch was the correct culprit.

[please use gerrit instead, 2016-11-02 16:32:29]

The build with the revert is passing again:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/27976

This patch was the correct culprit.