Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2470143007: Revert of predictors: Basic browsertest checks predictor learning. (Closed)

Created:
4 years, 1 month ago by Mathieu
Modified:
4 years, 1 month ago
Reviewers:
pasko, Benoit L, alexilin
CC:
chromium-reviews, shishir+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of predictors: Basic browsertest checks predictor learning. (patchset #9 id:160001 of https://codereview.chromium.org/2449323005/ ) Reason for revert: Created a flaky test: first occurrence at https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%281%29/builds/28933 Original issue's description: > predictors: Basic browsertest checks predictor learning. > > First stage for implementing ResourcePrefetchPredictor browsertests is to check > that the prefetch database is really filled after some navigations in browser. > Browsertest class provides convenient way to declare expected resources in the > test and then checks expectations internally that allows to write readable > tests. > > BUG=650253 > > Committed: https://crrev.com/e636e3bcc172f220dfadfd2121d238c9908185bb > Cr-Commit-Position: refs/heads/master@{#429966} TBR=pasko@chromium.org,lizeb@chromium.org,alexilin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=650253 Committed: https://crrev.com/3250e71949fa7d226e9c843ee28277b988306229 Cr-Commit-Position: refs/heads/master@{#430137}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -288 lines) Patch
D chrome/browser/predictors/resource_prefetch_predictor_browsertest.cc View 1 chunk +0 lines, -188 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.h View 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_test_util.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M chrome/browser/predictors/resource_prefetch_predictor_unittest.cc View 1 chunk +41 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
D chrome/test/data/predictors/html_subresources.html View 1 chunk +0 lines, -22 lines 0 comments Download
M testing/buildbot/filters/browser-side-navigation.linux.browser_tests.filter View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Mathieu
Created Revert of predictors: Basic browsertest checks predictor learning.
4 years, 1 month ago (2016-11-05 03:10:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470143007/1
4 years, 1 month ago (2016-11-05 03:10:44 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-05 03:12:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3250e71949fa7d226e9c843ee28277b988306229 Cr-Commit-Position: refs/heads/master@{#430137}
4 years, 1 month ago (2016-11-05 03:15:30 UTC) #7
alexilin
4 years, 1 month ago (2016-11-07 09:52:55 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2482833002/ by alexilin@chromium.org.

The reason for reverting is: Reland.

Powered by Google App Engine
This is Rietveld 408576698