Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2470143004: [test] Speed up some slow tests. (Closed)

Created:
4 years, 1 month ago by Yang
Modified:
4 years, 1 month ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[test] Speed up some slow tests. - split up cctest/test-api/Threading* - shortened mjsunit/math-floor-part* - split up cctest/test-serialize/CustomSnapshotDataBlob - skipped mjsunit/regress/regress-crbug-474297 unless gc-stress - shortened cctest/test-serialize/CodeSerializerLargeCodeObject R=jkummerow@chromium.org Committed: https://crrev.com/62937cf5335271698d47a4596813bdf2bacba4d5 Cr-Commit-Position: refs/heads/master@{#40753}

Patch Set 1 #

Total comments: 4

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -65 lines) Patch
M test/cctest/cctest.h View 1 chunk +11 lines, -5 lines 0 comments Download
M test/cctest/cctest.status View 7 chunks +7 lines, -18 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +17 lines, -28 lines 0 comments Download
M test/cctest/test-serialize.cc View 4 chunks +13 lines, -9 lines 0 comments Download
M test/mjsunit/math-floor-part2.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part3.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/math-floor-part4.js View 1 chunk +2 lines, -2 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Yang
4 years, 1 month ago (2016-11-03 11:27:55 UTC) #1
Jakob Kummerow
Yay! LGTM with comments. I'll change the description to include [test] for you. https://codereview.chromium.org/2470143004/diff/1/test/cctest/test-serialize.cc File ...
4 years, 1 month ago (2016-11-03 13:28:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470143004/20001
4 years, 1 month ago (2016-11-04 08:39:39 UTC) #6
Yang
https://codereview.chromium.org/2470143004/diff/1/test/cctest/test-serialize.cc File test/cctest/test-serialize.cc (right): https://codereview.chromium.org/2470143004/diff/1/test/cctest/test-serialize.cc#newcode613 test/cctest/test-serialize.cc:613: DisableTurbofan(); On 2016/11/03 13:28:40, Jakob Kummerow wrote: > As ...
4 years, 1 month ago (2016-11-04 08:39:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-04 09:04:18 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:22:12 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/62937cf5335271698d47a4596813bdf2bacba4d5
Cr-Commit-Position: refs/heads/master@{#40753}

Powered by Google App Engine
This is Rietveld 408576698